Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor into jcli-lib crate #3216

Closed
wants to merge 25 commits into from
Closed

Refactor into jcli-lib crate #3216

wants to merge 25 commits into from

Commits on Apr 13, 2021

  1. Add new jcli-lib crate to workspace 

    This is the beginning step for refactoring the jcli-lib crate from the
jcli binary crate. This is the starting commit for #3172
    @filip-dulic-bloxico
    filip-dulic-bloxico committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    a28223f View commit details
    Browse the repository at this point in the history

  2. transfer the same dependencies from jcli to jcli-lib

    @filip-dulic-bloxico
    filip-dulic-bloxico committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    d002b33 View commit details
    Browse the repository at this point in the history

  3. bulk transfer of jcli_lib code into jcli-lib crate

    @filip-dulic-bloxico
    filip-dulic-bloxico committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    232d99f View commit details
    Browse the repository at this point in the history

  4. refactor main library modules, transfer to new crate

    @filip-dulic-bloxico
    filip-dulic-bloxico committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    e445722 View commit details
    Browse the repository at this point in the history

  5. set jcli-lib as a dependency of jcli

    @filip-dulic-bloxico
    filip-dulic-bloxico committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    07fbb0c View commit details
    Browse the repository at this point in the history

  6. correct imports in new jcli-lib

    @filip-dulic-bloxico
    filip-dulic-bloxico committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    502f473 View commit details
    Browse the repository at this point in the history

  7. copy build.rs from jcli crate

    @filip-dulic-bloxico
    filip-dulic-bloxico committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    be60ecb View commit details
    Browse the repository at this point in the history

  8. remove unused dependencies from jcli

    @filip-dulic-bloxico
    filip-dulic-bloxico committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    b5235e9 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2021

  1. make structopt an optional feature, add to default features in Cargo … 

    …manifest
    @filip-dulic-bloxico
    filip-dulic-bloxico committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    92f5a70 View commit details
    Browse the repository at this point in the history

  2. feature gate structopt attributes for jcli_lib::address

    @filip-dulic-bloxico
    filip-dulic-bloxico committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    49c52d8 View commit details
    Browse the repository at this point in the history

  3. feature gate structopt attributes for jcli_lib::auto_complete 

    This module really doesn't make sense to have if the 'structopt'
feature is disabled. The gated attributes can be safely removed
as long as the entire module is gated.

I'm leaving the gated attributes in place, until the API is better
defined.
    @filip-dulic-bloxico
    filip-dulic-bloxico committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    fbc507d View commit details
    Browse the repository at this point in the history

  4. feature gate structopt attributes for jcli_lib::block

    @filip-dulic-bloxico
    filip-dulic-bloxico committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    422f282 View commit details
    Browse the repository at this point in the history

  5. feature gate structopt attributes for jcli_lib::certificate::*

    @filip-dulic-bloxico
    filip-dulic-bloxico committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    30fdb1f View commit details
    Browse the repository at this point in the history

  6. feature gate structopt attributes for jcli_lib::debug::*

    @filip-dulic-bloxico
    filip-dulic-bloxico committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    4f21efd View commit details
    Browse the repository at this point in the history

  7. feature gate structopt attributes for jcli_lib::key

    @filip-dulic-bloxico
    filip-dulic-bloxico committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    6525177 View commit details
    Browse the repository at this point in the history

  8. feature gate structopt attributes for jcli_lib::rest::*

    @filip-dulic-bloxico
    filip-dulic-bloxico committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    6584dd4 View commit details
    Browse the repository at this point in the history

  9. feature gate structopt attributes for jcli_lib::transaction::*

    @filip-dulic-bloxico
    filip-dulic-bloxico committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    a0bce01 View commit details
    Browse the repository at this point in the history

  10. feature gate structopt attributes for jcli_lib::utils::*

    @filip-dulic-bloxico
    filip-dulic-bloxico committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    5d2f1b4 View commit details
    Browse the repository at this point in the history

  11. feature gate structopt attributes for jcli_lib::vote::*

    @filip-dulic-bloxico
    filip-dulic-bloxico committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    1fdb6b7 View commit details
    Browse the repository at this point in the history

  12. feature gate structopt attributes for top-level lib.rs

    @filip-dulic-bloxico
    filip-dulic-bloxico committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    48ad2d8 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2021

  1. feature gate auto_complete module

    @filip-dulic-bloxico
    filip-dulic-bloxico committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    0c0a6bb View commit details
    Browse the repository at this point in the history

  2. add top-level docstrings to modules in crate

    @filip-dulic-bloxico
    filip-dulic-bloxico committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    247030b View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2021

  1. more doc strings for modules and public types

    @filip-dulic-bloxico
    filip-dulic-bloxico committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    004405f View commit details
    Browse the repository at this point in the history

  2. make crate::rest::v0 module public

    @filip-dulic-bloxico
    filip-dulic-bloxico committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    192d45f View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2021

  1. remove duplicate Seed structs, make Seed public for library

    @filip-dulic-bloxico
    filip-dulic-bloxico committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    d57f892 View commit details
    Browse the repository at this point in the history