Rename the MetricsServiceTrait to MetricsServiceExporter

input-output-hk · Oct 11, 2024 · 09cf2b3 · 09cf2b3
1 parent 570f3e3
commit 09cf2b3
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 11 deletions.
diff --git a/internal/mithril-metric/src/commons.rs b/internal/mithril-metric/src/commons.rs
@@ -109,7 +109,7 @@ macro_rules! build_metrics_service {
                 )*
             }
 
-            impl MetricsServiceTrait for $service {
+            impl MetricsServiceExporter for $service {
                 fn export_metrics(&self) -> StdResult<String> {
                     metrics_tools::export_metrics(&self.registry)
                 }
@@ -261,7 +261,7 @@ pub mod test_tools {
 mod tests {
     use std::collections::BTreeMap;
 
-    use crate::MetricsServiceTrait;
+    use crate::MetricsServiceExporter;
 
     use super::*;
     use prometheus::Registry;
@@ -373,7 +373,7 @@ mod tests {
         }
     }
 
-    impl MetricsServiceTrait for MetricsServiceExample {
+    impl MetricsServiceExporter for MetricsServiceExample {
         fn export_metrics(&self) -> StdResult<String> {
             metrics_tools::export_metrics(&self.registry)
         }

diff --git a/internal/mithril-metric/src/lib.rs b/internal/mithril-metric/src/lib.rs
@@ -6,4 +6,4 @@ mod server;
 
 pub use commons::*;
 pub use server::MetricsServer;
-pub use server::MetricsServiceTrait;
+pub use server::MetricsServiceExporter;
diff --git a/internal/mithril-metric/src/server.rs b/internal/mithril-metric/src/server.rs
@@ -13,7 +13,7 @@ use tokio::sync::oneshot::Receiver;
 use mithril_common::logging::LoggerExtensions;
 use mithril_common::StdResult;
 
-pub trait MetricsServiceTrait {
+pub trait MetricsServiceExporter {
     fn export_metrics(&self) -> StdResult<String>;
 }
 
@@ -36,19 +36,19 @@ impl IntoResponse for MetricsServerError {
 }
 
 /// The MetricsServer is responsible for exposing the metrics of the signer.
-pub struct MetricsServer<T: MetricsServiceTrait + Send + Sync> {
+pub struct MetricsServer<T: MetricsServiceExporter + Send + Sync> {
     server_port: u16,
     server_ip: String,
     metrics_service: Arc<T>,
     logger: Logger,
 }
 
-struct RouterState<T: MetricsServiceTrait + Send + Sync> {
+struct RouterState<T: MetricsServiceExporter + Send + Sync> {
     metrics_service: Arc<T>,
     logger: Logger,
 }
 
-impl<T: MetricsServiceTrait + Send + Sync + 'static> MetricsServer<T> {
+impl<T: MetricsServiceExporter + Send + Sync + 'static> MetricsServer<T> {
     /// Create a new MetricsServer instance.
     pub fn new(server_ip: &str, server_port: u16, metrics_service: Arc<T>, logger: Logger) -> Self {
         Self {
@@ -123,7 +123,7 @@ mod tests {
         }
     }
 
-    impl MetricsServiceTrait for PseudoMetricsService {
+    impl MetricsServiceExporter for PseudoMetricsService {
         fn export_metrics(&self) -> StdResult<String> {
             Ok("pseudo metrics".to_string())
         }

diff --git a/mithril-signer/src/metrics/service.rs b/mithril-signer/src/metrics/service.rs
@@ -1,4 +1,4 @@
-use mithril_metric::{build_metrics_service, metrics_tools, MetricsServiceTrait};
+use mithril_metric::{build_metrics_service, metrics_tools, MetricsServiceExporter};
 use prometheus::Registry;
 use slog::Logger;
 

diff --git a/mithril-signer/tests/test_extensions/state_machine_tester.rs b/mithril-signer/tests/test_extensions/state_machine_tester.rs
@@ -1,6 +1,6 @@
 #![allow(dead_code)]
 use anyhow::anyhow;
-use mithril_metric::{MetricsServiceTrait, MithrilMetric};
+use mithril_metric::{MetricsServiceExporter, MithrilMetric};
 use prometheus_parse::Value;
 use slog::Drain;
 use slog_scope::debug;