Merge pull request #2340 from input-output-hk/djo/2316/cleanup-legacy…

…-code-from-thales-era Cleanup legacy code from thales era
input-output-hk · Feb 26, 2025 · daedb00 · daedb00
2 parents 3f77f6b + dac8109
commit daedb00
Show file tree

Hide file tree

Showing 102 changed files with 2,246 additions and 7,242 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/docs/website/root/manual/develop/run-mithril-devnet.md b/docs/website/root/manual/develop/run-mithril-devnet.md
@@ -231,8 +231,6 @@ The networks will be queried every second and will display:
 === Mithril Network
 =====================================================================
 
->> Query pending certificate
-
 >> Query latest certificates
 [
   {

diff --git a/.../website/versioned_docs/version-maintained/manual/develop/run-mithril-devnet.md b/.../website/versioned_docs/version-maintained/manual/develop/run-mithril-devnet.md
@@ -231,8 +231,6 @@ The networks will be queried every second and will display:
 === Mithril Network
 =====================================================================
 
->> Query pending certificate
-
 >> Query latest certificates
 [
   {

diff --git a/internal/mithril-persistence/Cargo.toml b/internal/mithril-persistence/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "mithril-persistence"
-version = "0.2.46"
+version = "0.2.47"
 description = "Common types, interfaces, and utilities to persist data for Mithril nodes."
 authors = { workspace = true }
 edition = { workspace = true }

diff --git a/internal/mithril-persistence/src/database/version_checker.rs b/internal/mithril-persistence/src/database/version_checker.rs
@@ -304,6 +304,37 @@ mod tests {
         check_database_version(&connection, 4);
     }
 
+    #[test]
+    fn test_upgrade_with_migration_with_a_version_gap() {
+        let (_filepath, connection) =
+            create_sqlite_file("test_upgrade_with_migration_with_a_version_gap.sqlite3").unwrap();
+        let mut db_checker = DatabaseVersionChecker::new(
+            discard_logger(),
+            ApplicationNodeType::Aggregator,
+            &connection,
+        );
+
+        let alterations = "create table whatever (thing_id integer); insert into whatever (thing_id) values (1), (2), (3), (4);";
+        let migration = SqlMigration {
+            version: 3,
+            alterations: alterations.to_string(),
+        };
+        db_checker.add_migration(migration);
+        db_checker.apply().unwrap();
+        assert_eq!(1, get_table_whatever_column_count(&connection));
+        check_database_version(&connection, 3);
+
+        let alterations = "alter table whatever add column thing_content text; update whatever set thing_content = 'some content'";
+        let migration_with_version_gap = SqlMigration {
+            version: 10,
+            alterations: alterations.to_string(),
+        };
+        db_checker.add_migration(migration_with_version_gap);
+        db_checker.apply().unwrap();
+        assert_eq!(2, get_table_whatever_column_count(&connection));
+        check_database_version(&connection, 10);
+    }
+
     #[test]
     fn starting_with_migration() {
         let (_filepath, connection) = create_sqlite_file("starting_with_migration").unwrap();

diff --git a/mithril-aggregator/Cargo.toml b/mithril-aggregator/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "mithril-aggregator"
-version = "0.7.6"
+version = "0.7.7"
 description = "A Mithril Aggregator server"
 authors = { workspace = true }
 edition = { workspace = true }