-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Factorize crypto operation #1045
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alenar
commented
Jul 11, 2023
ghubertpalo
approved these changes
Jul 12, 2023
This in order to build more easilly single signers.
Plus don't generate party ids and operation certificates temp files if using a Custom generation method. In this case we asume that the given party ids have already all the OpCert & other temp files ready.
Alenar
force-pushed
the
ensemble/669/factorize-crypto-operation
branch
from
July 12, 2023 12:03
f4185bf
to
0f48b84
Compare
jpraynaud
approved these changes
Jul 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💪
It can: * aggregate single signatures into a multi signatures * build the aggregate verification key from its clerk. * verify a single signature
Alenar
force-pushed
the
ensemble/669/factorize-crypto-operation
branch
from
July 12, 2023 13:25
0f48b84
to
dea498c
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR introduce three new types in
mithril-common
in order to factorize crypto operation arround issuing single/multi signatures:protocol::SingleSigner
: Issue single signaturesprotocol::MultiSigner
: Aggregate single signatures, compute avk, and verify single signaturesprotocol::SignerBuilder
: A builder for the two previous types, handle the key registration..Pre-submit checklist
Issue(s)
Relates to #669