Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factorize crypto operation #1045

Merged
merged 15 commits into from
Jul 12, 2023
Merged

Factorize crypto operation #1045

merged 15 commits into from
Jul 12, 2023

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented Jul 10, 2023 •
edited
Loading

Content

This PR introduce three new types in mithril-common in order to factorize crypto operation arround issuing single/multi signatures:

  • protocol::SingleSigner: Issue single signatures
  • protocol::MultiSigner: Aggregate single signatures, compute avk, and verify single signatures
  • protocol::SignerBuilder: A builder for the two previous types, handle the key registration..

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Relates to #669

@github-actions
Copy link

github-actions bot commented Jul 10, 2023 •
edited
Loading

Test Results

    3 files  ±  0    16 suites  ±0   5m 27s ⏱️ - 1m 16s
635 tests +19  635 ✔️ +19  0 💤 ±0  0 ❌ ±0 
673 runs  +19  673 ✔️ +19  0 💤 ±0  0 ❌ ±0 

Results for commit dea498c. ± Comparison against base commit 311829e.

♻️ This comment has been updated with latest results.

@Alenar Alenar temporarily deployed to testing-preview July 10, 2023 16:23 — with GitHub Actions Inactive
@Alenar Alenar temporarily deployed to testing-preview July 11, 2023 09:04 — with GitHub Actions Inactive
@Alenar
Simplify setup_signers_from_stake_distribution in crypto helper
851f4df
@Alenar
Add kes secret key path to SignerFixture & party_id shortcut
be6d24c 
This in order to build more easilly single signers.
@Alenar
Add uniform stake distribution generation to fixture builder
7e045b4 
Plus don't generate party ids and operation certificates temp files if
using a Custom generation method. In this case we asume that the given
party ids have already all the OpCert & other temp files ready.
@Alenar
Add ability to change party_id seed to MithrilFixtureBuilder
465029a
@Alenar Alenar force-pushed the ensemble/669/factorize-crypto-operation branch from f4185bf to 0f48b84 Compare July 12, 2023 12:03
@Alenar Alenar temporarily deployed to testing-preview July 12, 2023 12:15 — with GitHub Actions Inactive
jpraynaud
jpraynaud approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

mithril-client/src/services/mithril_stake_distribution.rs Outdated Show resolved Hide resolved
mithril-common/src/protocol/multi_signer.rs Outdated Show resolved Hide resolved
mithril-common/src/protocol/multi_signer.rs Outdated Show resolved Hide resolved
mithril-common/src/protocol/signer_builder.rs Outdated Show resolved Hide resolved
mithril-common/src/protocol/signer_builder.rs Outdated Show resolved Hide resolved
mithril-common/src/protocol/signer_builder.rs Show resolved Hide resolved
mithril-common/src/protocol/signer_builder.rs Outdated Show resolved Hide resolved
@Alenar Alenar force-pushed the ensemble/669/factorize-crypto-operation branch from 0f48b84 to dea498c Compare July 12, 2023 13:25
@Alenar Alenar temporarily deployed to testing-preview July 12, 2023 13:34 — with GitHub Actions Inactive
@Alenar Alenar merged commit e9719b1 into main Jul 12, 2023
24 checks passed
@Alenar Alenar deleted the ensemble/669/factorize-crypto-operation branch July 12, 2023 14:02
@jpraynaud jpraynaud linked an issue Jul 12, 2023 that may be closed by this pull request
Factorize protocol crypto operations #669
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

@ghubertpalo ghubertpalo ghubertpalo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Factorize protocol crypto operations
3 participants
@Alenar @jpraynaud @ghubertpalo