Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1023 - fix flaky end-to-end tests #1050

Merged
merged 4 commits into from
Jul 11, 2023
Merged

#1023 - fix flaky end-to-end tests #1050

merged 4 commits into from
Jul 11, 2023

Conversation

ghubertpalo
Copy link
Collaborator

@ghubertpalo ghubertpalo commented Jul 11, 2023 •
edited
Loading

Content

This PR adds a patch to fix unstable CI end-to-end tests.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

None

Issue(s)

Closes #1023

@github-actions
Copy link

github-actions bot commented Jul 11, 2023 •
edited
Loading

Test Results

    3 files  ±0    16 suites  ±0   4m 49s ⏱️ -29s
616 tests ±0  616 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
654 runs  ±0  654 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit da54c0f. ± Comparison against base commit 6a8511b.

♻️ This comment has been updated with latest results.

@ghubertpalo ghubertpalo temporarily deployed to testing-preview July 11, 2023 09:48 — with GitHub Actions Inactive
@ghubertpalo ghubertpalo changed the title fix tar file pointer fix flaky end-to-end tests Jul 11, 2023
@ghubertpalo ghubertpalo changed the title fix flaky end-to-end tests #1023 - fix flaky end-to-end tests Jul 11, 2023
@ghubertpalo ghubertpalo temporarily deployed to testing-preview July 11, 2023 10:20 — with GitHub Actions Inactive
@ghubertpalo ghubertpalo temporarily deployed to testing-preview July 11, 2023 13:01 — with GitHub Actions Inactive
@ghubertpalo ghubertpalo temporarily deployed to testing-preview July 11, 2023 13:27 — with GitHub Actions Inactive
@ghubertpalo ghubertpalo marked this pull request as ready for review July 11, 2023 13:34
@ghubertpalo ghubertpalo temporarily deployed to testing-preview July 11, 2023 13:46 — with GitHub Actions Inactive
@ghubertpalo ghubertpalo temporarily deployed to testing-preview July 11, 2023 13:57 — with GitHub Actions Inactive
jpraynaud
jpraynaud approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ghubertpalo ghubertpalo merged commit 3ad37c0 into main Jul 11, 2023
24 checks passed
@ghubertpalo ghubertpalo deleted the ensemble/1023/flaky_e2e_ci branch July 11, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar left review comments

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

E2E tests are flaky in CI
3 participants
@ghubertpalo @Alenar @jpraynaud