-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy store adapters & fix prune of stake pool & epoch settings #1076
Conversation
Test Results 3 files ±0 16 suites ±0 6m 48s ⏱️ +28s Results for commit ef9c487. ± Comparison against base commit 5ea211e. This pull request removes 10 and adds 5 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
93ed08b
to
951c32d
Compare
2f4c0d4
to
946a895
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Except for the pruning of the stores in the end to end test by default, and few typos/questions
cc17d90
to
d31de78
Compare
It did not execute at all since the cursor wasn't consumed.
It did not execute at all since the cursor wasn't consumed.
In order to have some breath if something goes wrong while pruning enough data to keep that table lean.
This allow to synchronise pruning between tables, else pruning of data can occurs from tables that is used as a foreign key in another. Also, enable data pruning in the e2e tests for the aggregator in order to test it.
In order to ensure that if a retention limit is set it's not lower than a minimum value in order to not prune data that will be used at later epochs.
d31de78
to
ef9c487
Compare
Content
This PR remove the
StoreAdapter
implementation that were remaining in the aggregator database providers. Instead of using them in the dependencies it's the trait or even the provider itself that are used now.This simplify the usage of those database providers.
Also, this PR fix the prune of the Stake Pool & Epoch Settings, their queries were prepared but not executed since their cursors where not consumed. Tests have been added in order to check those cases.
Pre-submit checklist
Issue(s)
Closes #1053