Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dependencies #1289

Merged
merged 4 commits into from
Oct 10, 2023
Merged

Upgrade dependencies #1289

merged 4 commits into from
Oct 10, 2023

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Oct 9, 2023 •
edited
Loading

Content

This PR includes updates of Rust dependencies for the nodes and libraries.

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

jpraynaud
jpraynaud requested changes Oct 9, 2023
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update the Cargo.lock file in this commit

@github-actions
Copy link

github-actions bot commented Oct 9, 2023 •
edited
Loading

Test Results

    3 files  ±0    17 suites  ±0   6m 41s ⏱️ + 1m 9s
699 tests ±0  699 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
757 runs  ±0  757 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e68dab6. ± Comparison against base commit 4e8d15a.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume temporarily deployed to testing-preview October 9, 2023 16:39 — with GitHub Actions Inactive
jpraynaud
jpraynaud approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dlachaume dlachaume force-pushed the damien/upgrade-dependencies-2023-10-09 branch from cb343ec to a09cc4e Compare October 10, 2023 09:03
@dlachaume dlachaume temporarily deployed to testing-preview October 10, 2023 09:13 — with GitHub Actions Inactive
@dlachaume
Update docs dependencies and crate version
20710e1 
By running 'make upgrade' command.
@dlachaume
Update explorer dependencies and crate version
25d520f 
By running 'make upgrade' command.
@dlachaume
Upgrade Rust dependencies
edfd911 
By running 'cargo update' command.
@dlachaume
Update crates versions
e68dab6
@dlachaume dlachaume force-pushed the damien/upgrade-dependencies-2023-10-09 branch from a09cc4e to e68dab6 Compare October 10, 2023 12:21
jpraynaud
jpraynaud approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dlachaume dlachaume temporarily deployed to testing-preview October 10, 2023 12:32 — with GitHub Actions Inactive
@dlachaume dlachaume merged commit e1c36ba into main Oct 10, 2023
@dlachaume dlachaume deleted the damien/upgrade-dependencies-2023-10-09 branch October 10, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

@Alenar Alenar Alenar approved these changes

@ghubertpalo ghubertpalo Awaiting requested review from ghubertpalo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlachaume @Alenar @jpraynaud