Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mithril-stm WASM build #1290

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Fix mithril-stm WASM build #1290

merged 2 commits into from
Oct 12, 2023

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Oct 10, 2023 •
edited
Loading

Content

This PR fixes the compilation of the mithril-stm library when targeting WASM:

  • The batch signature verification provided by blst is not available with WASM
  • A build script detects a if WASM is targeted and applies the feature batch-verify-aggregates if this is not the case
  • The batch_verify function is available if the batch-verify-aggregates feature is activated

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #1254

@jpraynaud
Add build script to STM
7e6c683 
It will automatically detect WASM compilation and will deactivate batch verification
of aggregates, provided by BLST, which is not available in WASM.
@jpraynaud
Update 'mithril-stm' version
df47efe
@jpraynaud jpraynaud self-assigned this Oct 10, 2023
@github-actions
Copy link

Test Results

    3 files  ±0    17 suites  ±0   6m 38s ⏱️ +12s
699 tests ±0  699 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
757 runs  ±0  757 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit df47efe. ± Comparison against base commit e1c36ba.

@jpraynaud jpraynaud temporarily deployed to testing-preview October 10, 2023 16:14 — with GitHub Actions Inactive
curiecrypt
curiecrypt approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@curiecrypt curiecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jpraynaud jpraynaud merged commit 75dfb67 into main Oct 12, 2023
@jpraynaud jpraynaud deleted the jpraynaud/1254-fix-build-stm-wasm branch October 12, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curiecrypt curiecrypt curiecrypt approved these changes

@iquerejeta iquerejeta Awaiting requested review from iquerejeta

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpraynaud @curiecrypt