-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Number beacon in cardano transaction #1727
Block Number beacon in cardano transaction #1727
Commits on Jun 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ad690a7 - Browse repository at this point
Copy the full SHA ad690a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for f9479f9 - Browse repository at this point
Copy the full SHA f9479f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 765309d - Browse repository at this point
Copy the full SHA 765309dView commit details -
Adapt only code where other types don't need to be modified as well.
Configuration menu - View commit details
-
Copy full SHA for d680428 - Browse repository at this point
Copy the full SHA d680428View commit details -
Make CardanoTransactionsSignableBuilder use ChainPoint beacon
Making this change also result in updating `TransactionsImporter` and `BlockRangeRootRetriever` traits methods to use a chain point. Only `mithril-persistence` is adapted to this changes in this commit.
Configuration menu - View commit details
-
Copy full SHA for b0697b1 - Browse repository at this point
Copy the full SHA b0697b1View commit details -
Rename
LatestImmutableFileNumber
protocol message part to `LatestBl……ockNumber` Plus add it to the openapi as it was missing.
Configuration menu - View commit details
-
Copy full SHA for 203ceaf - Browse repository at this point
Copy the full SHA 203ceafView commit details -
Update BlockScanner signature to 'from BlockNumber until ChainPoint'
Before it was using an ImmutableFileNumber for both bounds
Configuration menu - View commit details
-
Copy full SHA for 754ca9a - Browse repository at this point
Copy the full SHA 754ca9aView commit details -
Make CardanoBlockScanner ignore it's upper bound
As we can't retrieve the immutable file number associated to a block number if it's not stored in the database (which will be typically the case of the upper bound).
Configuration menu - View commit details
-
Copy full SHA for cf581e1 - Browse repository at this point
Copy the full SHA cf581e1View commit details -
Make CardanoBlockScanner find it's lower bound using a trait
Ignoring the lower bound given has parameter. We ignore it since it's a block number and not a immutable file number and retrieving the later using the former is difficult since there's no available function to do that in the cardano api.
Configuration menu - View commit details
-
Copy full SHA for a16aef2 - Browse repository at this point
Copy the full SHA a16aef2View commit details -
Add
get_transaction_highest_block_number
to shared CardanoTransacti……onRepository As it will be needed from now on to compute the lower bound passed to the BlockScanner.
Configuration menu - View commit details
-
Copy full SHA for 488cf82 - Browse repository at this point
Copy the full SHA 488cf82View commit details -
Adapt Signer to the ChainPoint based Scanner & BlockRange retriever
With this change the lower bound of the scanner is now based on block number instead of immutable file number.
Configuration menu - View commit details
-
Copy full SHA for 017b28b - Browse repository at this point
Copy the full SHA 017b28bView commit details -
Update aggregator dependency construction
* Give the LowerBoundFinder needed by the block scanner * Remove the transaction 'store' build since it's already provided by the transaction 'repository' build
Configuration menu - View commit details
-
Copy full SHA for 0e1abf4 - Browse repository at this point
Copy the full SHA 0e1abf4View commit details -
Configuration menu - View commit details
-
Copy full SHA for fabb426 - Browse repository at this point
Copy the full SHA fabb426View commit details -
Make aggregator services & cardano transaction artifact builder use C…
…hainPoint Note: not compiling, we still need to update the `CardanoTransactionsSnapshot`.
Configuration menu - View commit details
-
Copy full SHA for b005c51 - Browse repository at this point
Copy the full SHA b005c51View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3847963 - Browse repository at this point
Copy the full SHA 3847963View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ab07cd - Browse repository at this point
Copy the full SHA 0ab07cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for ba6f7c9 - Browse repository at this point
Copy the full SHA ba6f7c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c7da5a - Browse repository at this point
Copy the full SHA 7c7da5aView commit details -
Remove now unused repository method fetching data using Immutables
Leaving only one required to compute the immutable block scanner lower bound.
Configuration menu - View commit details
-
Copy full SHA for 6eade6c - Browse repository at this point
Copy the full SHA 6eade6cView commit details -
Simplify CardanoTransaction signed entity type to
Epoch,BlockNumber
Instead of `Epoch,ChainPoint`. This is because we use this value as the upper bound of the blocks to import and can't known easily the associated block hash and slot number needed to constitute a ChainPoint (and we only need them for the lower bound to allow Pallas to known the starting point).
Configuration menu - View commit details
-
Copy full SHA for 686e219 - Browse repository at this point
Copy the full SHA 686e219View commit details -
Make SignableBuilder use a BlockNumber as target
This force to make the same change to the `TransactionImporter`, `TransactionRetriever`,`BlockScanner` and the `CardanoTransactionSnapshot`. When a lower bound was required this is when we use a `ChainPoint`(instead of a block number as before). To do this we added a new condition to the `GetCardanoTransactionQuery` that get the transactions with the highest block number in db (all transaction with a same block number also share their slot number and block hash). Co-authored-by: Sébastien Fauvel <[email protected]> Co-authored-by: Damien Lachaume <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8d1e1b8 - Browse repository at this point
Copy the full SHA 8d1e1b8View commit details -
Transfer immutable offsetting responsability to block scanner
Since the importer doesn't know anymore about immutable file numbers and the current block scanner role is precisely to fetch them for its `ImmutableBlockStreamer`. Co-authored-by: Sébastien Fauvel <[email protected]> Co-authored-by: Damien Lachaume <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dcceb41 - Browse repository at this point
Copy the full SHA dcceb41View commit details -
Introduce CardanoTransactionSigning config
To compute the block number to be signed based on the chain tip. Co-authored-by: Sébastien Fauvel <[email protected]> Co-authored-by: Damien Lachaume <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e95a839 - Browse repository at this point
Copy the full SHA e95a839View commit details -
Add
cardano_transactions_signing_config
to Aggregator configurationAnd pass them where needed to deduce a signed entity type from a time point. Also define a default configuration with: * `security_parameter`: 3000 * `step`: 90 End to end use more lax paramters (security param: 20, step: 15) since it's far faster and the last transactions we see included have a block number not that high (arround ~450).
Configuration menu - View commit details
-
Copy full SHA for 6505bc7 - Browse repository at this point
Copy the full SHA 6505bc7View commit details -
Cleanup CardanoDbBeacon based certificate & signed entity of CardanoT…
…ransaction Co-authored-by: Sébastien Fauvel <[email protected]> Co-authored-by: Damien Lachaume <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 865d9f3 - Browse repository at this point
Copy the full SHA 865d9f3View commit details -
Update aggregator fake default data
By running its `import.sh` script on a 'run only' end to end. Co-authored-by: Sébastien Fauvel <[email protected]> Co-authored-by: Damien Lachaume <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a5b5e4c - Browse repository at this point
Copy the full SHA a5b5e4cView commit details -
Update explorer to new CardanoTransaction signed entity beacon
Co-authored-by: Sébastien Fauvel <[email protected]> Co-authored-by: Damien Lachaume <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fc41440 - Browse repository at this point
Copy the full SHA fc41440View commit details
Commits on Jun 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8840169 - Browse repository at this point
Copy the full SHA 8840169View commit details -
Adjustements from PR reviews & fix broken doc tests
- Aggregator `cardano_transactions_signing_config.step` from 90 to 120. - Adjusts/fix multiples comments - Add missing types in `mithril-client` re-exported common types. Co-authored-by: Sébastien Fauvel <[email protected]> Co-authored-by: Damien Lachaume <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c80f17e - Browse repository at this point
Copy the full SHA c80f17eView commit details -
PR Review adjusments: enhance tests
Add a test that check the `get_transaction_highest_chain_point` of the `CardanoTransactionRepository` handle correcly the common case of multiple transaction with the same chain point. Clarify cardano transactions artificat builder tests. Co-authored-by: Sébastien Fauvel <[email protected]> Co-authored-by: Damien Lachaume <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 026f3d6 - Browse repository at this point
Copy the full SHA 026f3d6View commit details -
Upgrade crates versions and update Changelog
nodes: * Mithril-aggregator from `0.5.14` to `0.5.15` * Mithril-client from `0.8.1` to `0.8.2` * Mithril-client-cli from `0.9.0` to `0.9.1` * Mithril-client-wasm from `0.3.1` to `0.3.2` * Mithril-common from `0.4.11` to `0.4.12` * Mithril-signer from `0.2.139` to `0.2.140` websites: * Mithril-explorer from `0.7.0` to `0.7.1` internal: * Mithril-persistence from `0.2.1` to `0.2.2` test-lab * Mithril-aggregator-fake from `0.3.1` to `0.3.2` * Mithril-end-to-end from `0.4.13` to `0.4.14`
Configuration menu - View commit details
-
Copy full SHA for 70a8a61 - Browse repository at this point
Copy the full SHA 70a8a61View commit details