-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: implement certificate chain builder for tests #1999
Feat: implement certificate chain builder for tests #1999
Conversation
732212c
to
bf2b315
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀, thanks for the tool, it will make testing cases on the certificate chain much easier 🙏.
Just a comment regarding the exposure of data in the certificate_chain_builder
module.
It seems that we could set the following traits to private visibility:
GenesisCertificateProcessorFunc
StandardCertificateProcessorFunc
TotalSignersPerEpochProcessorFunc
The CertificateChainBuilderContext
struct could also switch to private by adding a #[cfg(test)]
attribute on the with_genesis_certificate_processor
and with_standard_certificate_processor
functions.
Do you think it could be a good idea?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…icateChainBuilder
…stand By splitting the epochs sequence in: - (epoch) sequence which is the list of epochs used when creating internal artifacts - (certificate_index, epoch) sequence which is explicitely used to create the final certificate chain.
bf2b315
to
9b63c01
Compare
You're right. Done ✔️
The usage of |
And add a factory for the 'CertificateChainBuilderContext'.
- 'mithril-common' from '0.4.71' to '0.4.72'.
Content
This PR includes the implementation of a Certificate Chain Builder for tests:
Pre-submit checklist