Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new GitHub action for creating releases #2000

Merged

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Oct 11, 2024

Content

This PR includes updates of the CI jobs that create pre-release and release to replace the unmaintained marvinpinto/action-automatic-releases action.

The https://github.com/softprops/action-gh-release is a suitable replacement for the pre-release job as it can handle the tasks previously managed by both marvinpinto/action-automatic-releases and tubone24/update_release , including updating the release notes body.

Examples of releases created from a fork of Mithril using these new GitHub Action: https://github.com/dlachaume/mithril/releases

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Relates to #1691

@dlachaume dlachaume self-assigned this Oct 11, 2024
Copy link

github-actions bot commented Oct 11, 2024

Test Results

    4 files  ±0     54 suites  ±0   9m 31s ⏱️ +6s
1 351 tests ±0  1 351 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 559 runs  ±0  1 559 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e8e634c. ± Comparison against base commit 0bc09f4.

♻️ This comment has been updated with latest results.

This replaces the unmaintained `marvinpinto/action-automatic-releases` action and handles the update of the release body, previously done by the `tubone24/update_release` action.
@dlachaume dlachaume force-pushed the dlachaume/1691/use-new-github-action-for-creating-releases branch from 04d6edb to e8e634c Compare October 14, 2024 08:28
@dlachaume dlachaume marked this pull request as ready for review October 14, 2024 08:28
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dlachaume dlachaume merged commit a404b02 into main Oct 14, 2024
45 of 46 checks passed
@dlachaume dlachaume deleted the dlachaume/1691/use-new-github-action-for-creating-releases branch October 14, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants