Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: update signer preloader refresh interval #2003

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Chore: update signer preloader refresh interval #2003

merged 2 commits into from
Oct 14, 2024

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Oct 14, 2024 •
edited
Loading

Content

This PR includes an update to the default preloader refresh interval of the signer which has been set to 12 hours instead of 2 hours.

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #1943

@jpraynaud
chore: reduce pace of preloader refresh in signer
c3b7af7 
From every 2 hours to 12 hours.
@jpraynaud
chore: bump crates versions
032f944 
- 'mithril-signer' from '0.2.196' to '0.2.197'.
@jpraynaud jpraynaud self-assigned this Oct 14, 2024
@jpraynaud jpraynaud mentioned this pull request Oct 14, 2024
Open
68 tasks
@github-actions GitHub Actions
Copy link

Test Results

    4 files  ±0     54 suites  ±0   9m 35s ⏱️ +10s
1 351 tests ±0  1 351 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 559 runs  ±0  1 559 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 032f944. ± Comparison against base commit 0bc09f4.

dlachaume
dlachaume approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jpraynaud jpraynaud merged commit 0dbfeab into main Oct 14, 2024
46 of 48 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/1943-update-signer-preloader-refresh-interval branch October 14, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@dlachaume dlachaume dlachaume approved these changes

@sfauvel sfauvel Awaiting requested review from sfauvel

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpraynaud @Alenar @dlachaume