Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: update dependencies runbook and script #2008

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Fix: update dependencies runbook and script #2008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4d7e6a
fix: reorder steps to build mithril-client-wasm before upgrading the …
dlachaume Oct 14, 2024
fb3a449
fix: prevent from incrementing `mithril-client-wasm` version in /pkg/
dlachaume Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions docs/runbook/upgrade-repository-dependencies/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,38 +84,40 @@ chore: upgrade doc dependencies
By running 'make upgrade' command.
```

### Upgrade the explorer dependencies
### Upgrade `www/` and `www-test/` dependencies

From the root of the repository, run:

[!IMPORTANT]: This command must be run before upgrading `mithril-explorer`.

```bash
cd mithril-explorer
make upgrade
cd mithril-client-wasm
make upgrade-www-deps
```

Create a dedicated commit, e.g.:

```bash
chore: upgrade explorer dependencies
chore: upgrade mithril client wasm 'www' and 'www-test' dependencies

By running 'make upgrade' command.
By running 'make upgrade-www-deps' command.
```

### Upgrade `www/` and `www-test/` dependencies
### Upgrade the explorer dependencies

From the root of the repository, run:

```bash
cd mithril-client-wasm
make upgrade-www-deps
cd mithril-explorer
make upgrade
```

Create a dedicated commit, e.g.:

```bash
chore: upgrade mithril client wasm 'www' and 'www-test' dependencies
chore: upgrade explorer dependencies

By running 'make upgrade-www-deps' command.
By running 'make upgrade' command.
```

### Bump Javascript packages versions
Expand All @@ -142,7 +144,7 @@ make install
Create a dedicated commit, e.g.:

```bash
chore: bump mithril client wasm 'www' and 'www-test' dependencies
chore: bump javascript packages versions

By running:
- 'make www-install' command in 'mithril-client-wasm'.
Expand Down
20 changes: 10 additions & 10 deletions docs/runbook/upgrade-repository-dependencies/upgrade_dependencies.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,6 @@ git commit -am "chore: upgrade doc dependencies

By running 'make upgrade' command."

# Upgrade the explorer dependencies
pushd mithril-explorer || exit
make upgrade
popd || exit
git commit -am "chore: upgrade explorer dependencies

By running 'make upgrade' command."

# Upgrade www/ and www-test/ dependencies
pushd mithril-client-wasm || exit
make upgrade-www-deps
Expand All @@ -43,11 +35,19 @@ git commit -am "chore: upgrade mithril client wasm 'www' and 'www-test' dependen

By running 'make upgrade-www-deps' command."

# Upgrade the explorer dependencies
pushd mithril-explorer || exit
make upgrade
popd || exit
git commit -am "chore: upgrade explorer dependencies

By running 'make upgrade' command."

# Bump Javascript packages versions

# Search all package.json files and bump the version
# and exclude `package.json` in `node_modules` folder
for package_json_file in $(find . -name package.json | grep -v "/node_modules/"); do
for package_json_file in $(find . -name package.json | grep -v "/node_modules/" | grep -v "/pkg/"); do
folder="$(dirname $package_json_file)"
pushd "$folder" || exit
npm version patch
Expand All @@ -66,7 +66,7 @@ pushd docs/website || exit
make install
popd || exit

git commit -am "chore: bump mithril client wasm 'www' and 'www-test' dependencies
git commit -am "chore: bump javascript packages versions

By running:
- 'make www-install' command in 'mithril-client-wasm'.
Expand Down
Loading