-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize logs in common, signer, and persistence #2010
Merged
Alenar
merged 7 commits into
main
from
djo/1981/standardize_logs_in_common_signer_persitence
Oct 15, 2024
Merged
Standardize logs in common, signer, and persistence #2010
Alenar
merged 7 commits into
main
from
djo/1981/standardize_logs_in_common_signer_persitence
Oct 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alenar
force-pushed
the
djo/1981/standardize_logs_in_common_signer_persitence
branch
from
October 15, 2024 13:13
7587cc5
to
b4c80be
Compare
Alenar
temporarily deployed
to
testing-preview
October 15, 2024 13:25
— with
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
October 15, 2024 13:25
— with
GitHub Actions
Inactive
dlachaume
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
jpraynaud
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
* Capitalize first letter of functionnal logs * Make function enter logs start with a `>>` followed by the function name. * Move away from main logs messages huge structures to keep them lean.
* Capitalize first letter of functionnal logs
* Capitalize first letter of functionnal logs * Make function enter logs start with a `>>` followed by the function name. * Add a little more data on runner function entries logs
…rrect ie: for a `MithrilProverService::<MKTreeStoreInMemory>` the source name generated was `MKTreeStoreInMemory>` instead of `MithrilProverService`.
* Moved a "function enter" log as close to the function start as possible.
* mithril-persistence from `0.2.29` to `0.2.30` * mithril-aggregator from `0.5.83` to `0.5.84` * mithril-common from `0.4.69` to `0.4.70` * mithril-signer from `0.2.200` to `0.2.201`
Alenar
force-pushed
the
djo/1981/standardize_logs_in_common_signer_persitence
branch
from
October 15, 2024 15:41
60e1b7d
to
9c21f44
Compare
Alenar
temporarily deployed
to
testing-preview
October 15, 2024 15:52
— with
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
October 15, 2024 15:52
— with
GitHub Actions
Inactive
Alenar
deleted the
djo/1981/standardize_logs_in_common_signer_persitence
branch
October 15, 2024 15:53
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
Following the light rules we decided to applies for logs when working on the aggregator (see #2009), this PR applies those rules on
mithril-signer
,mithril-common
andmithril-persistence
:>> function_name
.It also:
Pre-submit checklist
Issue(s)
Relates to #1981