-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activate metrics endpoint on aggregator #2022
Activate metrics endpoint on aggregator #2022
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I left few comments and suggestions below.
I have also pushed a commit with the missing configuration of the scraping Prometheus endpoint for the aggregator metrics in the infrastructure: a67d64a.
d2fe79f
to
eefc17b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just two minor issues.
Co-authored-by: Sébastien Fauvel <[email protected]>
… JoinSet completes
eefc17b
to
90d7374
Compare
90d7374
to
e35d60a
Compare
…kAggregatorRunner` during state machine tests
…er, fix typos and renaming
Co-authored-by: Sébastien Fauvel <[email protected]> Co-authored-by: DJO <[email protected]>
…d for proof - Implement `increment_by` function for `MetricCounter` to increment the counter by another value than '1'. - Renaming of `proof_cardano_transaction_total_served_since_startup` to `proof_cardano_transaction_total_proofs_served_since_startup`.
* mithril-metric from `0.1.0` to `0.1.1` * mithril-aggregator from `0.5.84` to `0.5.85`
e35d60a
to
7352335
Compare
Content
This PR includes:
certificate_detail_total_served_since_startup
(Counter)artifact_detail_cardano_db_total_served_since_startup
(Counter)artifact_detail_mithril_stake_distribution_total_served_since_startup
(Counter)artifact_detail_cardano_stake_distribution_total_served_since_startup
(Counter)artifact_detail_cardano_transaction_total_served_since_startup
(Counter)proof_cardano_transaction_total_proofs_served_since_startup
(Counter)proof_cardano_transaction_total_transactions_served_since_startup
(Counter)signer_registration_total_received_since_startup
(Counter)signature_registration_total_received_since_startup
(Counter)certificate_total_produced_since_startup
(Counter)artifact_cardano_db_total_produced_since_startup
(Counter)artifact_mithril_stake_distribution_total_produced_since_startup
(Counter)artifact_cardano_stake_distribution_total_produced_since_startup
(Counter)artifact_cardano_transaction_total_produced_since_startup
(Counter)runtime_cycle_success_since_startup
(Counter)runtime_cycle_total_since_startup
(Counter)ab
tests ontesting-preview
BEFORE merging the PRNumber of requests: 1000
Number of requests: 10 000
ab
tests ontesting-preview
AFTER merging the PRNumber of requests: 1000
Number of requests: 10 000
Pre-submit checklist
Issue(s)
Closes #1980