Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: clap arguments are always overriding configuration #2038

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Fix: clap arguments are always overriding configuration #2038

merged 2 commits into from
Oct 22, 2024

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Oct 22, 2024 •
edited
Loading

Content

This PR includes a fix that prevents clap arguments from systematically overriding the configuration with boolean arguments.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Relates to #1980

@dlachaume dlachaume self-assigned this Oct 22, 2024
jpraynaud
jpraynaud approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dlachaume
fix: assign the values of the clap boolean arguments to the configura…
878c74a 
…tion only when they are true.
@dlachaume
chore: upgrade crate versions
8a6fb72 
* mithril-aggregator from `0.5.85` to `0.5.86`
@dlachaume dlachaume force-pushed the ensemble/fix-clap-arguments-always-override-config branch from 0ea7b61 to 8a6fb72 Compare October 22, 2024 09:55
@github-actions GitHub Actions
Copy link

Test Results

    4 files  ±0     55 suites  ±0   10m 46s ⏱️ +20s
1 379 tests ±0  1 379 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 593 runs  ±0  1 593 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8a6fb72. ± Comparison against base commit ef8c283.

@dlachaume dlachaume merged commit 17b4319 into main Oct 22, 2024
48 checks passed
@dlachaume dlachaume deleted the ensemble/fix-clap-arguments-always-override-config branch October 22, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

@sfauvel sfauvel Awaiting requested review from sfauvel

Assignees

@dlachaume dlachaume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlachaume @Alenar @jpraynaud