Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: remove _counter suffix from aggregator metrics #2041

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Fix: remove _counter suffix from aggregator metrics #2041

merged 2 commits into from
Oct 22, 2024

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Oct 22, 2024 •
edited
Loading

Content

This PR includes a renaming of aggregator metrics, removing the _counter suffix.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Relates to #1980

@dlachaume dlachaume changed the title Dlachaume/remove counter suffixe from aggregator metrics Fix: remove _counter suffixe from aggregator metrics Oct 22, 2024
@dlachaume dlachaume self-assigned this Oct 22, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 22, 2024 •
edited
Loading

Test Results

    4 files  ±0     55 suites  ±0   10m 24s ⏱️ -2s
1 393 tests ±0  1 393 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 607 runs  ±0  1 607 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 90d15e9. ± Comparison against base commit d36e448.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume changed the title Fix: remove _counter suffixe from aggregator metrics Fix: remove _counter suffix from aggregator metrics Oct 22, 2024
jpraynaud
jpraynaud approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlachaume dlachaume force-pushed the dlachaume/remove-counter-suffixe-from-aggregator-metrics branch from 5c8e344 to 90d15e9 Compare October 22, 2024 15:21
@dlachaume dlachaume merged commit e431657 into main Oct 22, 2024
48 checks passed
@dlachaume dlachaume deleted the dlachaume/remove-counter-suffixe-from-aggregator-metrics branch October 22, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

@sfauvel sfauvel Awaiting requested review from sfauvel

Assignees

@dlachaume dlachaume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlachaume @Alenar @jpraynaud