Fix: ensure epoch consistency during epoch changes when signer is signing #2046
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes a fix that was triggered by flakiness failures on the CI.
The problem occurred when there was an epoch change after the signer had already begun its signature process.
To resolve this, the current epoch is now passed as a parameter when the signer retrieves the beacon to sign, instead of retrieving it with the ticker service, ensuring consistency throughout the signature process.
This fixes all the CI errors such as:
Mithril End to End test in failed: Minimum expected mithril stake distribution epoch not reached : 18 < 20
Pre-submit checklist
Issue(s)
Closes #2044