Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ensure epoch consistency during epoch changes when signer is signing #2046

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Oct 24, 2024

Content

This PR includes a fix that was triggered by flakiness failures on the CI.
The problem occurred when there was an epoch change after the signer had already begun its signature process.
To resolve this, the current epoch is now passed as a parameter when the signer retrieves the beacon to sign, instead of retrieving it with the ticker service, ensuring consistency throughout the signature process.

This fixes all the CI errors such as:
Mithril End to End test in failed: Minimum expected mithril stake distribution epoch not reached : 18 < 20

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #2044

@dlachaume dlachaume self-assigned this Oct 24, 2024
Copy link

github-actions bot commented Oct 24, 2024

Test Results

    4 files  ±0     55 suites  ±0   10m 32s ⏱️ +2s
1 395 tests ±0  1 395 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 609 runs  ±0  1 609 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2c18bec. ± Comparison against base commit 38b3203.

♻️ This comment has been updated with latest results.

This allows to remove the ticker service dependency from the `SignerCertifierService`.
@dlachaume dlachaume force-pushed the dlachaume/2044/flakiness-in-ci-e2e-tests branch from 385bf0f to 7fe21cf Compare October 24, 2024 10:24
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

* mithril-signer from `0.2.203` to `0.2.204`
@dlachaume dlachaume force-pushed the dlachaume/2044/flakiness-in-ci-e2e-tests branch from 7fe21cf to 2c18bec Compare October 24, 2024 10:45
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlachaume dlachaume merged commit b3fdad2 into main Oct 24, 2024
45 checks passed
@dlachaume dlachaume deleted the dlachaume/2044/flakiness-in-ci-e2e-tests branch October 24, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flakiness in e2e tests in CI
4 participants