Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: era markers and pool tools for Cardano 10.1 #2053

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Oct 25, 2024

Content

This PR primarily updates the era markers runbook and pool tools in infra to ensure compatibility with Cardano 10.1.

Documentation Updates:

  • docs/runbook/era-markers/README.md: Updated various Cardano CLI commands to include the CARDANO_ERA environment variable for querying UTXOs, building transactions, and submitting transactions.

Script Updates:

Miscellaneous:

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #2045

@jpraynaud jpraynaud self-assigned this Oct 25, 2024
Copy link

github-actions bot commented Oct 25, 2024

Test Results

    4 files  ±0     55 suites  ±0   10m 12s ⏱️ -23s
1 401 tests ±0  1 401 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 615 runs  ±0  1 615 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 5f105e8. ± Comparison against base commit aad95c1.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpraynaud jpraynaud merged commit 650e77d into main Oct 25, 2024
46 of 47 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/fix-cardano-node-10.1 branch October 25, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants