Fix Rust 1.83 clippy warnings #2148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using `cargo clippy --all-targets --all-features --fix`
…bols by adjusting their visibility so they're at most `pub(crate)`. Note: With rust `1.83` there's no more 'missing doc' exception for `cfg(test)` and `pub` symbols.
Those were before marked as public so they were excluded from the dead code analysis, but the previous commit adjusted their visibility to at most `pub(crate)`.
dlachaume
approved these changes
Nov 28, 2024
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
* mithril-metric from `0.1.2` to `0.1.3` * mithril-persistence from `0.2.37` to `0.2.38` * mithril-aggregator from `0.5.115` to `0.5.116` * mithril-common from `0.4.89` to `0.4.90` * mithril-relay from `0.1.27` to `0.1.28` * mithril-signer from `0.2.216` to `0.2.217`
Alenar
force-pushed
the
djo/2147/rust_1.83
branch
from
4859520 to
f399f24
Compare
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes fix for the new clippy warning raised in rust
1.83released today (27 November 2024).The two most common warnings solved are:
the following explicit lifetimes could be elided: 'aandelided lifetime has a namecfg(test)gated public items:pub(crate)).Pre-submit checklist
Issue(s)
Closes #2147