Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Gruvbox-themed callouts #42

Merged
merged 1 commit into from
Mar 7, 2024
Merged

feat: add Gruvbox-themed callouts #42

merged 1 commit into from
Mar 7, 2024

Conversation

ashemedai
Copy link
Contributor

@ashemedai ashemedai commented Jun 11, 2023

Picking up the work from #29:

  • define callouts in a theme-agnostic way, but kept colours in line with the callout colours from the original Obsidian theme
  • callouts have a small border
  • dropped the drop shadow since it distracted more visually than it supported

I played around with opacity of 0.3 for background-color and 0.5 for --callout-border-opacity but it becomes too bright for the dark theme.

These are the resulting unique looks (hope the colours come through correctly, my Firefox is currently displaying this as more faded than it in fact is, going to check colour management after posting this).
Edit: OK, think I fixed the colour disparity.
Edit 2: attempt 2 at the colour disparity fixing.

Dark
dark

Light
light

@ashemedai
Copy link
Contributor Author

@insanum Gentle ping.

@edofe99
Copy link

edofe99 commented Mar 7, 2024

Is there a way someone can pick this theme and actually maintain it?

@insanum insanum merged commit 4444361 into insanum:master Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants