Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General repository cleanup #321

Merged
merged 28 commits into from
May 12, 2024
Merged

General repository cleanup #321

merged 28 commits into from
May 12, 2024

Conversation

bpben
Copy link
Collaborator

@bpben bpben commented Sep 10, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2023

Codecov Report

Attention: Patch coverage is 80.00000% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 59.25%. Comparing base (8f9f23d) to head (883bb1a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
- Coverage   64.35%   59.25%   -5.10%     
==========================================
  Files          33       33              
  Lines        3316     3328      +12     
==========================================
- Hits         2134     1972     -162     
- Misses       1182     1356     +174     

@bpben bpben marked this pull request as ready for review March 8, 2024 14:27
@bpben bpben requested a review from j-t-t March 8, 2024 14:31
@bpben
Copy link
Collaborator Author

bpben commented May 12, 2024

I'm going to merge this - the code coverage decrease is odd - it's mainly around syntax corrections and I don't quite understand how that decreases the coverage. But without adding a bunch of new tests, I'm not sure how to correct that. Everything else works as expected, though.

@bpben bpben merged commit 39b9c69 into master May 12, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants