Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLA workflow #411

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Add CLA workflow #411

merged 1 commit into from
Mar 15, 2024

Conversation

walkowif
Copy link
Contributor

Signed-off-by: walkowif <[email protected]>
@walkowif walkowif requested a review from cicdguy March 11, 2024 14:10
@gowerc
Copy link
Collaborator

gowerc commented Mar 12, 2024

@walkowif - Apologies I'm not that versed in this, would you mind just explaining (in simple terms) what this is about and what this change does ?

@cicdguy
Copy link
Contributor

cicdguy commented Mar 12, 2024

Hi @gowerc, this is sort of like our DCO (Developer Certificate of Origin), but in the form of a CLA (Contributor License Agreement). See https://opensource.com/article/18/3/cla-vs-dco-whats-difference to know what these are.

This is to make sure that contributors acknowledge that they did not take code or data from somewhere else (closed source/restricted locations) before getting their PR merged or issues created.

@gowerc
Copy link
Collaborator

gowerc commented Mar 12, 2024

@cicdguy - Thanks for the link, and what does the updated action do exactly then ?

@cicdguy
Copy link
Contributor

cicdguy commented Mar 12, 2024

@cicdguy - Thanks for the link, and what does the updated action do exactly then ?

The workflow will trigger when a PR is updated (a comment is added or changes are made). The CLA bot will post a comment asking contributors to sign (see here for an example). Contributors then need to "sign" the CLA (see example here) and the signature is recorded for that contributor for that repository.

@gowerc
Copy link
Collaborator

gowerc commented Mar 12, 2024

Sorry do you have any alternative links. Apologies if I'm being dim but theres nothing that stands out to me on that ticket as an example of what you mean.

@cicdguy cicdguy merged commit edbf35f into main Mar 15, 2024
4 checks passed
@cicdguy cicdguy deleted the add-cla-workflow branch March 15, 2024 16:00
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2024
@gowerc
Copy link
Collaborator

gowerc commented Mar 19, 2024

@cicdguy, why was this merged? I was purposefully not merging this PR as I still had concerns about what the implication to getting open source contributors and the fact this might put off other companies from contributing / using the package. I also hadn't yet consulted with our Biostats stakeholders about if they were ok with this.

@cicdguy
Copy link
Contributor

cicdguy commented Mar 19, 2024

@epijim - should we allow repositories to opt out of this? See @gowerc's comments above.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants