Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-release tm_g_scatterplotmatrix document update #661

Merged
merged 11 commits into from
Feb 26, 2024
Merged

pre-release tm_g_scatterplotmatrix document update #661

merged 11 commits into from
Feb 26, 2024

Conversation

kartikeyakirar
Copy link
Contributor

@kartikeyakirar kartikeyakirar commented Feb 21, 2024 •
edited
Loading

part of #624

@kartikeyakirar kartikeyakirar mentioned this pull request Feb 21, 2024
Closed
26 tasks
@kartikeyakirar
merge back from pre-release
1bb3c1a 
Merge branch 'pre-release@main' into tm_g_scatterplotmatrix@pre-release@main

# Conflicts:
#	R/tm_g_scatterplotmatrix.R
#	man/tm_g_scatterplotmatrix.Rd
@averissimo averissimo self-assigned this Feb 26, 2024
averissimo
averissimo requested changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the code change should be reverted.

Added a few comments on documentation that I think either need to be changed, or would improve it (marked with optional).

R/tm_g_scatterplotmatrix.R Outdated Show resolved Hide resolved
R/tm_g_scatterplotmatrix.R Outdated Show resolved Hide resolved
R/tm_g_scatterplotmatrix.R Outdated Show resolved Hide resolved
R/tm_g_scatterplotmatrix.R Outdated Show resolved Hide resolved
R/tm_g_scatterplotmatrix.R Outdated Show resolved Hide resolved
R/tm_g_scatterplotmatrix.R Outdated Show resolved Hide resolved
kartikeyakirar and others added 6 commits February 26, 2024 19:32
@kartikeyakirar @averissimo
Update R/tm_g_scatterplotmatrix.R
de91b15 
Co-authored-by: André Veríssimo <[email protected]>
Signed-off-by: kartikeya kirar <[email protected]>
@kartikeyakirar @averissimo
Update R/tm_g_scatterplotmatrix.R
c5548d0 
Co-authored-by: André Veríssimo <[email protected]>
Signed-off-by: kartikeya kirar <[email protected]>
@kartikeyakirar @averissimo
Update R/tm_g_scatterplotmatrix.R
2ae9888 
Co-authored-by: André Veríssimo <[email protected]>
Signed-off-by: kartikeya kirar <[email protected]>
@kartikeyakirar @averissimo
Update R/tm_g_scatterplotmatrix.R
ba5e502 
Co-authored-by: André Veríssimo <[email protected]>
Signed-off-by: kartikeya kirar <[email protected]>
@kartikeyakirar @averissimo
Update R/tm_g_scatterplotmatrix.R
b594382 
Co-authored-by: André Veríssimo <[email protected]>
Signed-off-by: kartikeya kirar <[email protected]>
@kartikeyakirar
reverted the changes for get_scatterplotmatrix_stats
b9db727
averissimo
averissimo approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!

@kartikeyakirar kartikeyakirar merged commit 39ede58 into pre-release@main Feb 26, 2024
@kartikeyakirar kartikeyakirar deleted the tm_g_scatterplotmatrix@pre-release@main branch February 26, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@averissimo averissimo averissimo approved these changes

Assignees

@averissimo averissimo

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kartikeyakirar @averissimo