Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

898 save app state version 3 #1011

Merged
merged 134 commits into from
Mar 28, 2024
Merged
Changes from 1 commit
Commits
Show all changes
134 commits
Select commit Hold shift + click to select a range
9ee3c22
create functions to grab and restore app state
Aug 24, 2023
4278015
add state manager module
Aug 24, 2023
edfd6be
amend documentation
Aug 24, 2023
1b3b524
insert state manager into filter manager
Aug 24, 2023
1b149e8
rename one funciton
Aug 24, 2023
a7405d9
omit action buttons from grabs
Aug 24, 2023
6a0cc29
re-click until grab fully reset
Aug 24, 2023
130fbc8
encapsulate creating grabs
Aug 24, 2023
3b963fa
reorder file
Aug 24, 2023
634b5e8
amend documentation
Aug 24, 2023
d452326
remove dewclassing of grabbed values to keep dates and date times
Aug 25, 2023
e131b71
handle POSIXct in airDatePickerInput
Aug 25, 2023
7c21911
Merge e131b713094b85a6f73f85d82b97a5ff8e3bce87 into 54c683b92f845075a…
chlebowa Aug 25, 2023
709c4ef
[skip actions] Restyle files
github-actions[bot] Aug 28, 2023
c2e0be4
[skip actions] Roxygen Man Pages Auto Update
dependabot-preview[bot] Aug 28, 2023
735650c
remove storing initial input state as always empty
Aug 28, 2023
f854b9d
spelling
Aug 28, 2023
556c1bb
spelling
Aug 28, 2023
696375e
Merge branch 'main' into 898_save_app_state@main
chlebowa Sep 8, 2023
3e40918
use native shiny bookmarking
Sep 8, 2023
0c22dcd
open bookmarks in new window
Sep 8, 2023
b9e3e37
minor update to defauts
Sep 11, 2023
958c8d7
Merge branch 'main' into 898_save_app_state2@main
Dec 14, 2023
edb94dc
fix logic operators
Dec 14, 2023
67f8be5
fix state manager server definition and call
Dec 14, 2023
5606703
add hook to teal to set shiny option for bookmarking
Dec 15, 2023
5b47506
fix bookmarking and restoring callbacks
Dec 15, 2023
a583e23
add missing arguments in state manager and add return value in snapsh…
Dec 15, 2023
47cc2a5
properly call public methods of session object
Dec 15, 2023
81f10fb
add more missing arguments to state manager module
Dec 15, 2023
5bb0125
clean up docs
Dec 15, 2023
9e9c9de
rebuild module
Dec 15, 2023
e2fea5d
remove grab_state function
Dec 15, 2023
ca24e29
add argument checks to state manager module
Dec 15, 2023
3ec250d
remove filter panel exclusion
Dec 15, 2023
c9bbb54
don't store initial app state
Dec 15, 2023
63eb738
clean up comemnts
Dec 15, 2023
c3d40cf
init returns ui as function
Dec 18, 2023
ac363d2
use state manager module always
Dec 18, 2023
f24dd8c
Merge branch 'main' into 898_save_app_state3@main
Dec 18, 2023
b02fee4
Merge branch 'main' into 898_save_app_state3@main
Mar 13, 2024
c0f854c
all managers return
Mar 13, 2024
159e337
isolate manager_manager_module
Mar 13, 2024
0eb331e
rename manager_manager where it is used
Mar 13, 2024
ef6c049
move snapshot_manager and state_manager to manager manager
Mar 13, 2024
d25397c
rename module
Mar 13, 2024
b8b7b5c
shorten line
Mar 13, 2024
712a5c3
remove superfluous utility function
Mar 13, 2024
1084353
rename module to bookmark_manager
Mar 13, 2024
b950e31
rename grab to bookmark
Mar 13, 2024
a3d2147
fix typo
Mar 14, 2024
2149306
separate utility function in filter manager
Mar 14, 2024
af3ebfc
move renaming of global filtered data list
Mar 14, 2024
8ba143a
rename flat filtered data list and tweak utility function
Mar 14, 2024
6a3689a
rename filtered_data_list to datasets
Mar 14, 2024
fe0afb0
rename filtered_data_flat to datasets_flat
Mar 14, 2024
e59ab91
improve documentation for flatten_datasets
Mar 14, 2024
2b08206
add logging to all manager modules
Mar 14, 2024
3b82671
update name of programmatically clicked button
Mar 14, 2024
4371359
fix erroneous log
Mar 14, 2024
5d62ff4
remove delayed module initiation when starting from bookmark
Mar 14, 2024
23d408d
bug fix: missing argument value
Mar 14, 2024
c4b669c
fix update in example module
Mar 14, 2024
6d07bd2
improve logs in bookmark manager
Mar 14, 2024
43752bf
add bookmark exclusions
Mar 14, 2024
cd6c6bc
add code comment
Mar 14, 2024
fc3872a
modify button titles
Mar 15, 2024
8181ca6
remove superfluous CSS
Mar 15, 2024
07fa52f
change CSS class names
Mar 15, 2024
d896983
adjust style of bnon-first children in manager_table_row
Mar 15, 2024
6fbf146
Merge branch 'main' into 898_save_app_state3@main
chlebowa Mar 15, 2024
ed34a94
update code comment
Mar 15, 2024
2495fb3
simplify 'when from bookmark' condition
Mar 15, 2024
81f9346
Merge branch '898_save_app_state3@main' of github.com:insightsenginee…
Mar 15, 2024
5b5a1e2
replace bookmarkButton with action Button
Mar 15, 2024
debf0f2
amend documentation
Mar 15, 2024
24966a6
amend NEWS
Mar 15, 2024
ed94c39
rearrange code
Mar 15, 2024
38c9598
[skip style] [skip vbump] Restyle files
github-actions[bot] Mar 15, 2024
fa33460
fix spelling
Mar 18, 2024
9ac1fbd
Merge branch 'main' into 898_save_app_state3@main
chlebowa Mar 18, 2024
4dcc66c
improve flow control condition
Mar 18, 2024
882c1cf
amend unit tests
Mar 18, 2024
9db31ac
Merge branch '898_save_app_state3@main' of github.com:insightsenginee…
Mar 18, 2024
40d7cb9
assign return value in wunder_bar server
Mar 18, 2024
6b99ded
simplify unit test for snapshot manager
Mar 18, 2024
2b81ce2
add unit tests for wunder_bar module
Mar 18, 2024
47f93dd
Merge branch 'main' into 898_save_app_state3@main
chlebowa Mar 19, 2024
7888356
Merge branch 'main' into 898_save_app_state3@main
chlebowa Mar 19, 2024
68a7a0d
Merge branch 'main' into 898_save_app_state3@main
chlebowa Mar 19, 2024
a766110
remove delay on starting report previewer
Mar 20, 2024
40bed62
exclude all buttons (app-wide) from bookmark
Mar 20, 2024
7e3aed9
Merge branch 'main' into 898_save_app_state3@main
chlebowa Mar 20, 2024
92391a5
simplify code
Mar 21, 2024
a83b42c
change condition for initiating reporte previewer module
Mar 21, 2024
e2836b0
Merge branch 'main' into 898_save_app_state3@main
Mar 21, 2024
9d7d7b9
restoreValue
gogonzo Mar 22, 2024
557364c
remove browser
gogonzo Mar 22, 2024
be642f5
trigger
Mar 22, 2024
d36aac6
Merge branch 'main' into 898_save_app_state3@main
Mar 22, 2024
55bf1e0
add documentation for restoreValue
Mar 22, 2024
75ffb21
add function for comparing bookmarked states
Mar 22, 2024
4b94872
reorganize code
Mar 22, 2024
72bce64
amend documentation for restoreValue
Mar 22, 2024
c4e7556
move storing values to respective modules
Mar 25, 2024
c0d1e32
correct for namespace when restoring filter in module_teal
Mar 25, 2024
1b716d2
[skip roxygen] [skip vbump] Roxygen Man Pages Auto Update
dependabot-preview[bot] Mar 25, 2024
02a7db4
modify restoreValue
Mar 25, 2024
320014e
update documentation for restoreValue
Mar 25, 2024
5dbf498
clean up bookmark exclusions in bookmark manager
Mar 25, 2024
02b6710
modify storing filter state on bookmark
Mar 25, 2024
9e0f213
add comment headers
Mar 25, 2024
5c1896e
add enforcement of server-side bookmarks
Mar 25, 2024
ae46faa
register bookmark exclusions in snapshot manager
Mar 25, 2024
3423345
[skip style] [skip vbump] Restyle files
github-actions[bot] Mar 25, 2024
0e25d4c
[skip roxygen] [skip vbump] Roxygen Man Pages Auto Update
dependabot-preview[bot] Mar 25, 2024
e1df2fd
remove agruments in bookmark manager
Mar 25, 2024
b01a395
fix return value
Mar 25, 2024
5294f7c
exclude buttons from bookmark in wunder bar
Mar 25, 2024
56c55a0
amend documentation for snapshot and bookmark managers
Mar 25, 2024
8aac98c
extend message in bookmarks_identical
Mar 25, 2024
bf8b39b
teal_bookmarkable flags
Mar 26, 2024
d4a2b4d
only set app id on filter when missing
Mar 26, 2024
9edf512
Bookmarking info (#1184)
gogonzo Mar 28, 2024
92890d5
remove test
gogonzo Mar 28, 2024
30e8b28
trigger
Mar 28, 2024
33a5ba7
Merge branch 'main' into 898_save_app_state3@main
chlebowa Mar 28, 2024
a3659db
fix docs collate
gogonzo Mar 28, 2024
d3a0e09
fix docs
gogonzo Mar 28, 2024
7b40974
[skip roxygen] [skip vbump] Roxygen Man Pages Auto Update
dependabot-preview[bot] Mar 28, 2024
0aca94c
trigger
Mar 28, 2024
97c2efb
adding testing
gogonzo Mar 28, 2024
b40bd15
Merge branch '898_save_app_state3@main' of github.com:insightsenginee…
gogonzo Mar 28, 2024
6682d75
revert NEWS update
Mar 28, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
omit action buttons from grabs
Aleksander Chlebowski committed Aug 24, 2023
commit a7405d9ae11c18309f0dd1d771d6d237ae78b8c4
5 changes: 4 additions & 1 deletion R/module_state_manager.R
Original file line number Diff line number Diff line change
@@ -180,8 +180,11 @@ app_state_grab <- function() {
input <- session$input

ans <- lapply(names(input), function(i) {
list(id = i, value = as.vector(input[[i]]))
if (!inherits(input[[i]], "shinyActionButtonValue")) {
list(id = i, value = as.vector(input[[i]]))
}
})
ans <- Filter(Negate(is.null), ans)

excluded_ids <- paste(c("filter_panel", "filter_manager", "snapshot_manager", "state_manager"), collapse = "|")
included_ids <- grep(excluded_ids, vapply(ans, `[[`, character(1L), "id"), value = TRUE, invert = TRUE)