Improve the author autocompletion and ammend conference acceptnace test

Signed-off-by: Iuliana Voinea <[email protected]>
inspirehep · Jan 31, 2018 · 7bb48e2 · 7bb48e2
1 parent c14fded
commit 7bb48e2
Show file tree

Hide file tree

Showing 4 changed files with 40 additions and 4 deletions.
diff --git a/inspirehep/modules/forms/static/js/forms/affiliations_typeahead.js b/inspirehep/modules/forms/static/js/forms/affiliations_typeahead.js
@@ -31,7 +31,7 @@ define([
     this.dataEngine = new Bloodhound({
       name: 'affiliations',
       remote: {
-        url: '/api/institutions/_suggest?affiliation:%QUERY',
+        url: '/api/institutions/_suggest?affiliation=%QUERY',
         filter: function(response) {
           return $.map(response.affiliation[0].options, function(el) { return el.payload });
         }

diff --git a/inspirehep/modules/records/receivers.py b/inspirehep/modules/records/receivers.py
@@ -160,8 +160,16 @@ def populate_author_suggest(sender, json, *args, **kwargs):
     if 'authors.json' not in json.get('$schema'):
         return
 
+    author_paths = [
+        'name.preferred_name',
+        'name.value',
+        'native_name',
+        'other_names',
+        'previous_names',
+    ]
+
     name = get_value(json, 'name.value', '')
-    input_values = [name]
+    input_values = [el for el in chain.from_iterable([force_list(get_value(json, path)) for path in author_paths])]
 
     record = get_value(json, 'self.$ref', '')
 
@@ -262,6 +270,7 @@ def populate_conference_suggest(sender, json, *args, **kwargs):
         'cnum',
         'acronyms',
         'address.country_code',
+        'alternative_titles',
         'series.name',
         'titles.source',
         'titles.subtitle',

diff --git a/tests/acceptance/literature/test_literature_new_form.py b/tests/acceptance/literature/test_literature_new_form.py
@@ -217,7 +217,7 @@ def test_journal_info_autocomplete_title(login):
 def test_conference_info_autocomplete_title(login):
     create_literature.go_to()
     assert create_literature.write_conference(
-        'autrans',
+        'IN2',
         'IN2P3 School of Statistics, 2012-05-28, Autrans, FR',
     ).has_error()
 

diff --git a/tests/unit/records/test_records_receivers.py b/tests/unit/records/test_records_receivers.py
@@ -56,8 +56,19 @@ def test_populate_author_suggest():
     record = {
         '$schema': 'http://localhost:5000/schemas/records/authors.json',
         'name': {
+            'preferred_name': 'Alexander Aab',
             'value': 'Aab, Alexander',
         },
+        'native_name': [
+          'Alexandru, Aab',
+        ],
+        'other_names': [
+            'Alexandru, Ab',
+            'Alexander, Ab',
+        ],
+        'previous_names': [
+          'Alexis, Aban'
+        ],
         'self': {
             '$ref': 'http://localhost:5000/api/authors/bar'
         },
@@ -68,7 +79,13 @@ def test_populate_author_suggest():
     populate_author_suggest(None, record)
 
     expected = {
-        'input': ['Aab, Alexander'],
+        'input': ['Alexander Aab',
+                  'Aab, Alexander',
+                  'Alexandru, Aab',
+                  'Alexandru, Ab',
+                  'Alexander, Ab',
+                  'Alexis, Aban',
+                  ],
         'output': 'Aab, Alexander',
         'payload': {
             '$ref': 'http://localhost:5000/api/authors/bar',
@@ -496,6 +513,13 @@ def test_populate_conference_suggest():
                 'title': 'A title',
             },
         ],
+        'alternative_titles': [
+            {
+                'source': 'An alternative source',
+                'subtitle': 'An alternative subtitle',
+                'title': 'An alternative title',
+            },
+        ],
         'opening_date': '2009-03-12',
         'self': {
             '$ref': 'http://localhost:5000/api/conferences/bar'
@@ -520,6 +544,9 @@ def test_populate_conference_suggest():
             'A source',
             'A subtitle',
             'A title',
+            'An alternative source',
+            'An alternative subtitle',
+            'An alternative title',
             '2009-03-12',
             'Batavia',
             'Berlin',