Fix crash in autocomplete API for Institutions #2795
Conversation
I fixed and improved the autocomplete feature for institutions by using a completion type suggester. Signed-off-by: Iuliana Voinea <[email protected]>
* Adds real INSPIRE use cases to user related fixtures. * Amends permission tests to use the new fixtures.
fixtures: extend user fixtures
| @@ -31,7 +31,7 @@ define([ | |||
| this.dataEngine = new Bloodhound({ | |||
| name: 'affiliations', | |||
| remote: { | |||
| url: '/api/institutions?q=affautocomplete:%QUERY*', | |||
| url: '/api/institutions?q=affiliation_suggest:%QUERY*', | |||
There was a problem hiding this comment.
I believe, url shoud be, '/api/institutions/_suggest?affiliation=%QUERY'
| @@ -31,7 +31,7 @@ define([ | |||
| this.dataEngine = new Bloodhound({ | |||
| name: 'affiliations', | |||
| remote: { | |||
| url: '/api/institutions?q=affautocomplete:%QUERY*', | |||
| url: '/api/institutions?q=affiliation_suggest:%QUERY*', | |||
| filter: function(response) { | |||
| return $.map(response.hits.hits, function(el) { return el }); | |||
There was a problem hiding this comment.
and the hits are probably under, response.affiliation[0].options instead .hits.hits thing.
There was a problem hiding this comment.
return el.payload maybe?
There was a problem hiding this comment.
And be sure everything inside https://github.com/inspirehep/inspire-next/pull/2795/files#diff-d5957147cc784ce12f5bc9c0855e7628R47 template is being populated https://github.com/inspirehep/inspire-next/blob/master/inspirehep/modules/records/receivers.py#L335 .Otherwise they should be removed from the template or if necessary should be added to payload.
There was a problem hiding this comment.
do you know, why map is used here since mapper returns the element itself in the first place. @jmartinm ?
I fixed and improved the autocomplete feature for institutions by using a completion type suggester. Signed-off-by: Iuliana Voinea <[email protected]>
Signed-off-by: Iuliana Voinea <[email protected]>
Signed-off-by: Iuliana Voinea <[email protected]>
ghost
removed
the
|
Superseded by #3006. |
Description
I fixed and improved the autocomplete feature for institutions by using
a completion type suggester.
Signed-off-by: Iuliana Voinea [email protected]
Related Issue
Motivation and Context
Checklist:
RFCand look for it).