-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(aws-lambda): added performance improvements #1315
Draft
kirrg001
wants to merge
17
commits into
main
Choose a base branch
from
short-fix-lambda
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29b4a66
to
9f730fe
Compare
dad39ed
to
83ae371
Compare
ecca478
to
e21523a
Compare
e21523a
to
70558a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs https://jsw.ibm.com/browse/INSTA-13498
CASES
The results are always a little different. Factors like the speed of AWS, network and the backend replies plays a role.
Heartbeat performance fix
Was extracted from this PR and released already.
0c001c8
We have seen too many random errors regarding failed heartbeat requests to the layer.
Backend down / Host not found
Current layer
Average Response Time: 367.958ms
Average Billed Duration: 1502.000ms
Local branch
Average Response Time: 350.958ms
Average Billed Duration: 295.500ms
Backend slow / timeout (8 spans, no span batching)
Current layer
Average Response Time: 962.348ms
Average Billed Duration: 1567.000ms
Local branch
Average Response Time: 974.408ms
Average Billed Duration: 1356.900ms
Backend performs (8 spans, no span batching)
Current layer
Average Response Time: 949.076ms
Average Billed Duration: 904.267ms
Local branch
Average Response Time: 957.742ms
Average Billed Duration: 882.929ms
Average Backend Response Time: 65.178ms
Very similar. BUT there was a bug which executed invocations on the next invocation. Thats why current layer has similar results.
10 spans (one /traces, one /bundle)
Backend slow / timeout (100 spans, span batching enabled)
Backend performs (Span batching 100 spans)
current layer
Average Response Time: 10280.682ms
Average Billed Duration: 10231.250ms
local branch
Average Response Time: 10270.244ms
Average Billed Duration: 10195.500ms
Average Backend Response Time: 59.806ms