Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tracing): make activation robust against exotic Array.find override #227

Merged
merged 1 commit into from
Apr 24, 2020

Conversation

basti1302
Copy link
Contributor

  • Make instrumentation robust against Array.prototype.find() returns -1 instead of undefined montagejs/collections#178.
  • Make check for disabled instrumentation stricter (the keys provided in config.tracing.disabledTracers/INSTANA_DISABLED_TRACERS need to be an exact, case-insensitive match of the instrumentation file now). If you have used this configuration option and relied on the fact that this was a string.contains check previously, you might need to update your config.

- Make instrumentation robust against montagejs/collections#178.
- Make check for disabled instrumentation stricter (the keys provided in config.tracing.disabledTracers/INSTANA_DISABLED_TRACERS need to be an exact, case-insensitive match of the instrumentation file now). If you have used this configuration option and relied on the fact that this was a string.contains check previously, you might need to update your config.
@basti1302 basti1302 merged commit c66ea57 into master Apr 24, 2020
@basti1302 basti1302 deleted the montagejs-collections branch April 24, 2020 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant