Skip to content

Commit

Permalink
feat(mgmt): use unified dashboard endpoints (#239)
Browse files Browse the repository at this point in the history
Because

- Pipeline and credit endpoints have different params and schemas.
- Some of the information served by the existing endpoints will be
handled by the pipeline run feature.

This commit

- Applies contracts defined in
instill-ai/protobufs#435
  • Loading branch information
jvallesm authored Nov 26, 2024
1 parent 1baa8cd commit 1f223b1
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 4 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/integration-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,9 @@ jobs:
- name: Install k6
run: |
go install go.k6.io/xk6/cmd/xk6@v${{ env.XK6_VERSION }}
xk6 build v${{ env.K6_VERSION }} --with github.com/grafana/xk6-sql && sudo cp k6 /usr/bin
xk6 build v${{ env.K6_VERSION }} \
--with github.com/grafana/xk6-sql@v${{ env.XK6_SQL_VERSION }} \
--with github.com/grafana/xk6-sql-driver-postgres@v${{ env.XK6_SQL_POSTGRES_VERSION }} && sudo cp k6 /usr/bin
- name: Run ${{ matrix.component }} integration test (latest)
run: |
Expand Down
24 changes: 21 additions & 3 deletions config/settings-env/endpoints.json
Original file line number Diff line number Diff line change
Expand Up @@ -208,12 +208,12 @@
"input_query_strings": []
},
{
"endpoint": "/v1beta/metrics/vdp/pipeline/trigger-count",
"url_pattern": "/v1beta/metrics/vdp/pipeline/trigger-count",
"endpoint": "/v1beta/pipeline-runs/count",
"url_pattern": "/v1beta/pipeline-runs/count",
"method": "GET",
"timeout": "30s",
"input_query_strings": [
"namespaceId",
"requesterId",
"start",
"stop"
]
Expand Down Expand Up @@ -250,6 +250,18 @@
"filter"
]
},
{
"endpoint": "/v1beta/pipeline-runs/query-charts",
"url_pattern": "/v1beta/pipeline-runs/query-charts",
"method": "GET",
"timeout": "30s",
"input_query_strings": [
"requesterId",
"aggregationWindow",
"start",
"stop"
]
},
{
"endpoint": "/v1beta/model-runs/count",
"url_pattern": "/v1beta/model-runs/count",
Expand Down Expand Up @@ -450,6 +462,12 @@
"method": "POST",
"timeout": "30s"
},
{
"endpoint": "/core.mgmt.v1beta.MgmtPublicService/ListPipelineTriggerChartRecordsV0",
"url_pattern": "/core.mgmt.v1beta.MgmtPublicService/ListPipelineTriggerChartRecordsV0",
"method": "POST",
"timeout": "30s"
},
{
"endpoint": "/core.mgmt.v1beta.MgmtPublicService/ListPipelineTriggerTableRecords",
"url_pattern": "/core.mgmt.v1beta.MgmtPublicService/ListPipelineTriggerTableRecords",
Expand Down

0 comments on commit 1f223b1

Please sign in to comment.