feat(blob): relay file download and upload to minio #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yougigun
requested review from
donch1989,
jvallesm,
heiruwu,
pinglin and
xiaofei-du
as code owners
Yougigun
force-pushed
the
gary/ins-6281-implement-blob-plugin
branch
from
3045df8 to
c02b2ed
Compare
heiruwu
approved these changes
Oct 28, 2024
heiruwu
pushed a commit
that referenced
this pull request
Nov 5, 2024
🤖 I have created a release *beep* *boop* --- ## [0.29.0-beta](v0.28.1-beta...v0.29.0-beta) (2024-11-05) ### Features * **blob:** relay file download and upload to minio ([#261](#261)) ([ec27223](ec27223)) * **run:** pipeline/model runs and metrics APIs ([#265](#265)) ([c5f1a8d](c5f1a8d)) ### Bug Fixes * **blob:** build the blob plugin in image ([#263](#263)) ([24fc718](24fc718)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
In the blob refactor, MinIO's presigned URL is not user-friendly, so we provide an Instill-encoded URL.
This commit
enables the API gateway to decode and relay the request to MinIO.