Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore empty chunk from chunk pipeline #114

Merged
merged 1 commit into from
Oct 14, 2024
Merged

fix: ignore empty chunk from chunk pipeline #114

merged 1 commit into from
Oct 14, 2024

Conversation

Yougigun
Copy link
Contributor

Because:

  • There is a typo in 'enterprise'.
  • Sometimes the chunk pipeline returns an empty chunk.

This commit:

  • Corrects the typo.
  • Filters out the empty chunks.

@Yougigun Yougigun merged commit 983374f into main Oct 14, 2024
10 checks passed
@Yougigun Yougigun deleted the gary/fix-prevent-empty-chunk branch October 14, 2024 09:57
@droplet-bot droplet-bot mentioned this pull request Oct 8, 2024
Merged
Yougigun pushed a commit that referenced this pull request Oct 15, 2024
@droplet-bot
chore(main): release 0.18.0-alpha (#113)
e1cedf3 
🤖 I have created a release *beep* *boop*
---


##
[0.18.0-alpha](v0.17.0-alpha...v0.18.0-alpha)
(2024-10-15)


### Features

* add check on text prompt
([#115](#115))
([b612e82](b612e82))
* add pipeline metadata in error message
([#112](#112))
([d0a5875](d0a5875))


### Bug Fixes

* **artifact:** fix minio "get file by path"
([#116](#116))
([25cf426](25cf426))
* ignore empty chunk from chunk pipeline
([#114](#114))
([983374f](983374f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvallesm jvallesm Awaiting requested review from jvallesm jvallesm is a code owner

@donch1989 donch1989 Awaiting requested review from donch1989 donch1989 is a code owner

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

Assignees
No one assigned
Labels
instill core
Projects
No open projects
🔮 Instill Core
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yougigun @droplet-bot