Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(metric): reintroduce /metrics/vdp/pipeline/triggers endpoint #243

Merged
merged 1 commit into from
Oct 23, 2024
Merged

fix(metric): reintroduce /metrics/vdp/pipeline/triggers endpoint #243

merged 1 commit into from
Oct 23, 2024

Conversation

jvallesm
Copy link
Collaborator

Because

  • Pipeline metrics list endpoint was removed but it has a client.

This commit

  • Reintroduces the endpoint contract. It will be removed with the new
    dashboard design.

@jvallesm jvallesm self-assigned this Oct 23, 2024
@jvallesm
Copy link
Collaborator Author

jvallesm commented Oct 23, 2024 •
edited
Loading

QA ✔️

In addition to integration tests (that require instill-ai/api-gateway#259 to pass), I tried it on a local build and the broken page renders now ✅
CleanShot 2024-10-23 at 13 17 46

@jvallesm jvallesm marked this pull request as ready for review October 23, 2024 11:30
@jvallesm jvallesm merged commit d595d16 into main Oct 23, 2024
13 checks passed
@jvallesm jvallesm deleted the jvalles/fix-reintroduce-triggers-metrics-endpoint branch October 23, 2024 13:50
@droplet-bot droplet-bot mentioned this pull request Oct 23, 2024
Merged
donch1989 pushed a commit that referenced this pull request Oct 24, 2024
@droplet-bot
chore(main): release 0.20.2-beta (#244)
c84e555 
🤖 I have created a release *beep* *boop*
---


##
[0.20.2-beta](v0.20.1-beta...v0.20.2-beta)
(2024-10-23)


### Bug Fixes

* **metric:** reintroduce /metrics/vdp/pipeline/triggers endpoint
([#243](#243))
([d595d16](d595d16))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donch1989 donch1989 Awaiting requested review from donch1989 donch1989 is a code owner

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

Assignees

@jvallesm jvallesm

Labels
instill core
Projects
No open projects
🔮 Instill Core
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jvallesm @droplet-bot