Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ray): update dockerfile package string delimiter #125

Closed
wants to merge 1 commit into from
Closed

fix(ray): update dockerfile package string delimiter #125

wants to merge 1 commit into from

Conversation

heiruwu
Copy link
Member

@heiruwu heiruwu commented Mar 27, 2024

Because

  • Package string with whitespaces is interpreted as separate string

This commit

  • fix pip install not correctly install packages

@heiruwu heiruwu requested a review from joremysh as a code owner July 18, 2024 21:00
@heiruwu heiruwu force-pushed the main branch 3 times, most recently from 37fd5f5 to ffba765 Compare July 18, 2024 21:45
@joremysh
Copy link
Collaborator

there are some conflicts

@heiruwu
Copy link
Member Author

heiruwu commented Aug 29, 2024

PR no longer relevant, close now

@heiruwu heiruwu closed this Aug 29, 2024
@heiruwu heiruwu deleted the fix-build-string branch October 1, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joremysh joremysh Awaiting requested review from joremysh joremysh is a code owner

Assignees
No one assigned
Labels
instill core
Projects
No open projects
🔮 Instill Core
Status: 👋 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heiruwu @joremysh @droplet-bot