Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spelling per #105 #107

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

jjasghar
Copy link
Member

PR #105 needs some new words added to the spelling dictionary.

Copy link
Member

@markstur markstur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Knowlege and butvis are both typos so let's not add those

Also... YIKES!... a re-sort regarding order of uppercase vs lower happened and so this PR is a big re-sort again. Not good. Let's not go back and forth on that. PR should be simple additions and if we need to fix the sort again let's do that in a commit whichever order is preferred(?).

@jjasghar
Copy link
Member Author

i just used :<,'>sort 😭

I'm assuming that would be this would be the same with sort too right?

@markstur
Copy link
Member

i just used :<,'>sort 😭

I'm assuming that would be this would be the same with sort too right?

:%sort i would be case-insensitive to keep the current a's with A's, bees with Bees. 🐝

add a u for bonus removal of dups.
I don't really have a preference (okay maybe case-insensitive) but don't like it thrashing back and forth

PR instructlab#105 needs some new words added to the spelling dictionary.

Signed-off-by: JJ Asghar <[email protected]>
@jjasghar jjasghar force-pushed the jjasghar/update_spelling branch from d3fac57 to 7d730c9 Compare June 26, 2024 21:53
@jjasghar
Copy link
Member Author

OK, i got it fixed :)

Copy link
Member

@markstur markstur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

such a pretty diff, thanks!

Sorry for the extra work. I'm thinking maybe I should not have allowed the last re-sort so you kind of paid the price on this one.

@nathan-weinberg nathan-weinberg merged commit 7c50cee into instructlab:main Jun 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants