Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add policy document for using GitHub actions in workflows #45

Merged
merged 1 commit into from
May 28, 2024

Conversation

bjhargrave
Copy link
Contributor

Closes #12

Copy link
Member

@hickeyma hickeyma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGM, thanks @bjhargrave.
One thing, would it be worth discussing "secrets"?

Copy link
Member

@nathan-weinberg nathan-weinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @bjhargrave!

@bjhargrave
Copy link
Contributor Author

bjhargrave commented May 16, 2024

One thing, would it be worth discussing "secrets"?

I think a doc on secret management for the github organization is also a good idea. There could be a list of secrets, their purpose, how they are managed, who is responsible for rotation if needed, etc.

Copy link
Member

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this in general. I have a couple of minor suggestions, including making sure we file something to track the follow-up work.

docs/github-actions-use-policy.md Outdated Show resolved Hide resolved
docs/github-actions-use-policy.md Show resolved Hide resolved
docs/github-actions-use-policy.md Outdated Show resolved Hide resolved
Add policy document for using GitHub actions in workflows

Closes instructlab#12

Signed-off-by: BJ Hargrave <[email protected]>
Copy link
Member

@hickeyma hickeyma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@russellb Do you mind reviewing this again?

@hickeyma hickeyma requested a review from russellb May 24, 2024 14:10
Copy link
Member

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this!

@russellb russellb merged commit 6ab4e85 into instructlab:main May 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a document which describes the policy on the use of GitHub actions
5 participants