Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InstructLab macOS App #94

Merged
merged 1 commit into from
Jun 18, 2024
Merged

InstructLab macOS App #94

merged 1 commit into from
Jun 18, 2024

Conversation

jjasghar
Copy link
Member

This is a proposal for creating a InstructLab Application

@jjasghar jjasghar force-pushed the jjasghar/instructlab-app branch 2 times, most recently from 07cb0c9 to 9671dc6 Compare June 13, 2024 21:40
Copy link
Contributor

@leseb leseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m okay with the idea. Anything that can ease the adoption and improve the user experience is great. Thanks for working on this! Just a few nits.

Next time, could you push to your personal fork instead of pushing directly to the "instructlab" remote? It’s cluttering the branches. We prefer to keep the branches clean, showing only "main" or release branches, rather than in-progress work. Thanks!

@jjasghar jjasghar changed the title InstructLab App proposal InstructLab macOS App Jun 14, 2024
Copy link
Contributor

@leseb leseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nits, missed those during my initial review, almost there thanks!

This is a proposal for creating a InstructLab Application

Co-authored-by: Lisa Waugh <[email protected]>
Co-authored-by: Sébastien Han <[email protected]>
Signed-off-by: JJ Asghar <[email protected]>
@jjasghar jjasghar force-pushed the jjasghar/instructlab-app branch from 8075fdb to 73c1e6a Compare June 17, 2024 15:36
Copy link
Contributor

@leseb leseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@lhawthorn lhawthorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging.

@lhawthorn lhawthorn merged commit c62403b into main Jun 18, 2024
4 checks passed
@leseb leseb deleted the jjasghar/instructlab-app branch June 18, 2024 09:48
@jjasghar
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants