-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InstructLab macOS App #94
Conversation
07cb0c9
to
9671dc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m okay with the idea. Anything that can ease the adoption and improve the user experience is great. Thanks for working on this! Just a few nits.
Next time, could you push to your personal fork instead of pushing directly to the "instructlab" remote? It’s cluttering the branches. We prefer to keep the branches clean, showing only "main" or release branches, rather than in-progress work. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just nits, missed those during my initial review, almost there thanks!
This is a proposal for creating a InstructLab Application Co-authored-by: Lisa Waugh <[email protected]> Co-authored-by: Sébastien Han <[email protected]> Signed-off-by: JJ Asghar <[email protected]>
8075fdb
to
73c1e6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Merging.
This is a proposal for creating a InstructLab Application