-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add discord e2e status reporting #200
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleg S <[email protected]>
nathan-weinberg
approved these changes
Dec 17, 2024
alimaredia
approved these changes
Dec 17, 2024
4 tasks
RobotSail
added a commit
to RobotSail/instructlab
that referenced
this pull request
Dec 18, 2024
Since we have recently added Discord as another chat platform, we should also report the status of E2E jobs there in addition to Slack. This commit introduces this capability by mirroring a PR that was made in instructlab/eval: instructlab/eval#200 Signed-off-by: Oleg S <[email protected]>
6 tasks
RobotSail
added a commit
to RobotSail/training
that referenced
this pull request
Dec 18, 2024
Since we have recently added Discord as another chat platform, we should also report the status of E2E jobs there in addition to Slack. This commit introduces this capability by mirroring a PR that was made in instructlab/eval: instructlab/eval#200 Signed-off-by: Oleg S <[email protected]>
RobotSail
added a commit
to RobotSail/sdg
that referenced
this pull request
Dec 18, 2024
Since we have recently added Discord as another chat platform, we should also report the status of E2E jobs there in addition to Slack. This commit introduces this capability by mirroring a PR that was made in instructlab/eval: instructlab/eval#200 Signed-off-by: Oleg S <[email protected]>
mergify bot
added a commit
to instructlab/instructlab
that referenced
this pull request
Dec 18, 2024
Since we have recently added Discord as another chat platform, we should also report the status of E2E jobs there in addition to Slack. This commit introduces this capability by mirroring a PR that was made in instructlab/eval: instructlab/eval#200 Signed-off-by: Oleg S <[email protected]> **Checklist:** - [x] **Commit Message Formatting**: Commit titles and messages follow guidelines in the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/#summary). - [ ] [Changelog](https://github.com/instructlab/instructlab/blob/main/CHANGELOG.md) updated with breaking and/or notable changes for the next minor release. - [ ] Documentation has been updated, if necessary. - [ ] Unit tests have been added, if necessary. - [ ] Functional tests have been added, if necessary. - [ ] E2E Workflow tests have been added, if necessary. Approved-by: cdoern Approved-by: nathan-weinberg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR begins addressing instructlab/community#410 by adding a GitHub action to report e2e results to Discord.
Signed-off-by: Oleg S [email protected]