Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to nextjs and add github oauth #353

Merged
merged 1 commit into from
May 18, 2024

Conversation

nerdalert
Copy link
Member

  • Refactored for nextjs
  • Oauth with github as a provider
  • eslint cleanups
  • Server side rendering for api calls via nextjs

@vishnoianil I refactored in contribute. The CSS might need some cleanup on it without Tailwind. We can adjust when you're available. Ty!

image

@nerdalert nerdalert force-pushed the nextjs-oauth branch 6 times, most recently from 61048d3 to 4cf929d Compare May 17, 2024 07:23
@nerdalert nerdalert requested a review from vishnoianil May 17, 2024 14:55
Copy link
Collaborator

@Gregory-Pereira Gregory-Pereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments but super impressed at the quick turnarournd + content size, amazing job!

.gitignore Outdated Show resolved Hide resolved
ui/.env.example Outdated Show resolved Hide resolved
ui/package.json Outdated Show resolved Hide resolved
ui/package.json Outdated Show resolved Hide resolved
ui/src/app/api/jobs/route.ts Show resolved Hide resolved
ui/src/components/Jobs/Failed/index.tsx Show resolved Hide resolved
ui/src/components/Jobs/Pending/index.tsx Show resolved Hide resolved
ui/src/components/Jobs/Running/index.tsx Show resolved Hide resolved
ui/src/components/ThemeToggle/ThemeToggle.tsx Outdated Show resolved Hide resolved
ui/src/utils/tableUtils.ts Show resolved Hide resolved
@nerdalert nerdalert force-pushed the nextjs-oauth branch 2 times, most recently from 4cfb6e1 to 202a641 Compare May 17, 2024 20:16
Copy link
Collaborator

@Gregory-Pereira Gregory-Pereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets get this in and iterate from there

@nerdalert nerdalert force-pushed the nextjs-oauth branch 2 times, most recently from 4f82381 to 13affb2 Compare May 17, 2024 23:04
- refactored for nextjs
- Oauth for github
- eslint cleanups
- server side rendering for api calls via nextjs

Signed-off-by: Brent Salisbury <[email protected]>
@nerdalert
Copy link
Member Author

@vishnoianil think we're ready to go here.

@mergify mergify bot merged commit 3e75fff into instructlab:main May 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants