Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary requirement for qna.yaml in ContextAwareChunker #351

Merged

Conversation

khaledsulayman
Copy link
Member

Signed-off-by: Khaled Sulayman [email protected]

@khaledsulayman khaledsulayman changed the title Remove unnecessary dependency on qna.yaml in ContextAwareChunker Remove unnecessary requirement for qna.yaml in ContextAwareChunker Nov 8, 2024
@mergify mergify bot added the ci-failure label Nov 8, 2024
@khaledsulayman khaledsulayman force-pushed the ks-remove-load-qna-from-chunker branch from ea6ec75 to 663b5d5 Compare November 8, 2024 16:01
@mergify mergify bot removed the ci-failure label Nov 8, 2024
Copy link
Contributor

@bbrowning bbrowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! It feels good to remove dead code 😄

@mergify mergify bot added the one-approval label Nov 8, 2024
@mergify mergify bot removed the one-approval label Nov 8, 2024
@mergify mergify bot merged commit fc709af into instructlab:main Nov 8, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants