Ensure knowledge docs are cloned into unique dirs #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were attempting to clone multiple knowledge documents into the same destination directory, leading to failures generating data for any run that contained 2+ knowledge leaf nodes. Now, we clone docs into a guaranteed unique (via `tempfile.mkdtemp`) subdirectory per knowledge leaf node. Just using a subdirectory per leaf node could still have led to collisions if the user ran data generation twice within one minute, which is why this goes the extra step of using `mkdtemp` for guaranteed uniqueness. Fixes instructlab#404 Signed-off-by: Ben Browning <[email protected]>
aakankshaduggal
approved these changes
Nov 27, 2024
|
@Mergifyio backport release-v0.6 |
✅ Backports have been created
|
|
Still waiting on e2e-medium that is taking its sweet time working through some compositional skill testing, unrelated to this change. For the sake of expediency, I'm going to manually push the merge button on this one and get CI starting to run on the backport PR so they can happen simultaneously. |
mergify bot
added a commit
that referenced
this pull request
Nov 27, 2024
Ensure knowledge docs are cloned into unique dirs (backport #416)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were attempting to clone multiple knowledge documents into the same destination directory, leading to failures generating data for any run that contained 2+ knowledge leaf nodes.
Now, we clone docs into a guaranteed unique (via
tempfile.mkdtemp) subdirectory per knowledge leaf node. Just using a subdirectory per leaf node could still have led to collisions if the user ran data generation twice within one minute, which is why this goes the extra step of usingmkdtempfor guaranteed uniqueness.Fixes #404