Enhance the responsiveness of the login experience #216
Conversation
samarpita-bhaumik
force-pushed
the
main
branch
from
3d03559 to
d4f211c
Compare
There was a problem hiding this comment.
Hi @samarpita-bhaumik, would you be able to run npm run pretty and then commit the changes. This should fix the linting issues. I will then approve and merge. Thanks!
…ples Signed-off-by: Ash Evans <[email protected]> Signed-off-by: Samarpita Bhaumik <[email protected]>
Signed-off-by: Ash Evans <[email protected]> Signed-off-by: Samarpita Bhaumik <[email protected]>
Signed-off-by: Nathan Weinberg <[email protected]> Signed-off-by: Samarpita Bhaumik <[email protected]>
I updated the githublogin.tsx by removing the Page and PageSection tags, replacing them with div tags. Additionally, I modified the githublogin.css to include both vertical and horizontal scrolling, ensuring the page adapts to any window size. Signed-off-by: Samarpita Bhaumik <[email protected]>
Signed-off-by: Patryk-Pierzchala1 <[email protected]> Signed-off-by: Samarpita Bhaumik <[email protected]>
Signed-off-by: Patryk-Pierzchala1 <[email protected]> Signed-off-by: Samarpita Bhaumik <[email protected]>
Signed-off-by: Ash Evans <[email protected]> Signed-off-by: Samarpita Bhaumik <[email protected]>
Signed-off-by: Ash Evans <[email protected]> Signed-off-by: Samarpita Bhaumik <[email protected]>
Signed-off-by: Ash Evans <[email protected]> Signed-off-by: Samarpita Bhaumik <[email protected]>
…t function. Signed-off-by: Ash Evans <[email protected]> Signed-off-by: Samarpita Bhaumik <[email protected]>
…ctlab Signed-off-by: Ash Evans <[email protected]> Signed-off-by: Samarpita Bhaumik <[email protected]>
Signed-off-by: Anil Vishnoi <[email protected]> Signed-off-by: Samarpita Bhaumik <[email protected]>
Signed-off-by: Anil Vishnoi <[email protected]> Signed-off-by: Samarpita Bhaumik <[email protected]>
Signed-off-by: Anil Vishnoi <[email protected]> Signed-off-by: Samarpita Bhaumik <[email protected]>
Signed-off-by: Anil Vishnoi <[email protected]> Signed-off-by: Samarpita Bhaumik <[email protected]>
Signed-off-by: Anil Vishnoi <[email protected]> Signed-off-by: Samarpita Bhaumik <[email protected]>
Signed-off-by: Anil Vishnoi <[email protected]> Signed-off-by: Samarpita Bhaumik <[email protected]>
Signed-off-by: Anil Vishnoi <[email protected]> Signed-off-by: Samarpita Bhaumik <[email protected]>
Signed-off-by: Anil Vishnoi <[email protected]> Signed-off-by: Samarpita Bhaumik <[email protected]>
and knowledge contribution Signed-off-by: Anil Vishnoi <[email protected]> Signed-off-by: Samarpita Bhaumik <[email protected]>
and about model page. Signed-off-by: Anil Vishnoi <[email protected]> Signed-off-by: Samarpita Bhaumik <[email protected]>
Signed-off-by: Anil Vishnoi <[email protected]> Signed-off-by: Samarpita Bhaumik <[email protected]>
Signed-off-by: Anil Vishnoi <[email protected]> Signed-off-by: Samarpita Bhaumik <[email protected]>
Signed-off-by: Anil Vishnoi <[email protected]> Signed-off-by: Samarpita Bhaumik <[email protected]>
Signed-off-by: Anil Vishnoi <[email protected]> Signed-off-by: Samarpita Bhaumik <[email protected]>
Bumps [next-auth](https://github.com/nextauthjs/next-auth) from 4.24.7 to 4.24.8. - [Release notes](https://github.com/nextauthjs/next-auth/releases) - [Commits](https://github.com/nextauthjs/next-auth/compare/[email protected]@4.24.8) --- updated-dependencies: - dependency-name: next-auth dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Samarpita Bhaumik <[email protected]>
Signed-off-by: Brent Salisbury <[email protected]> Signed-off-by: Samarpita Bhaumik <[email protected]>
Signed-off-by: Ash Evans <[email protected]> Signed-off-by: Samarpita Bhaumik <[email protected]>
…t function. Signed-off-by: Ash Evans <[email protected]> Signed-off-by: Samarpita Bhaumik <[email protected]>
…ctlab Signed-off-by: Ash Evans <[email protected]> Signed-off-by: Samarpita Bhaumik <[email protected]>
Signed-off-by: Anil Vishnoi <[email protected]>
Signed-off-by: Anil Vishnoi <[email protected]> Signed-off-by: Samarpita Bhaumik <[email protected]>
Signed-off-by: Anil Vishnoi <[email protected]>
Signed-off-by: Anil Vishnoi <[email protected]>
Signed-off-by: Anil Vishnoi <[email protected]> Signed-off-by: Samarpita Bhaumik <[email protected]>
Signed-off-by: Anil Vishnoi <[email protected]> Signed-off-by: Samarpita Bhaumik <[email protected]>
Signed-off-by: Anil Vishnoi <[email protected]>
and knowledge contribution Signed-off-by: Anil Vishnoi <[email protected]> Signed-off-by: Samarpita Bhaumik <[email protected]>
and about model page. Signed-off-by: Anil Vishnoi <[email protected]>
Signed-off-by: Anil Vishnoi <[email protected]> Signed-off-by: Samarpita Bhaumik <[email protected]>
Signed-off-by: Anil Vishnoi <[email protected]> Signed-off-by: Samarpita Bhaumik <[email protected]>
Signed-off-by: Anil Vishnoi <[email protected]> Signed-off-by: Samarpita Bhaumik <[email protected]>
Udated the lint issues Signed-off-by: Samarpita Bhaumik <[email protected]>
samarpita-bhaumik
force-pushed
the
main
branch
from
fa7960e to
03e953b
Compare
Signed-off-by: Samarpita Bhaumik <[email protected]>
|
@aevo98765 can you please check now. Is it okay? |
|
Still linting errors. If you run It should mirror the attachment |
Signed-off-by: Ash Evans <[email protected]>
|
@samarpita-bhaumik I have made the changes. Hopefully the lint process is clearer for you for in the future. If not I would be happy to chat. Thanks. |
|
@aevo98765 extremely sorry for the trouble actually I manually did lint correction for this file. Will surely check this from next time. Thank you so much for the help.😅 |
|
@samarpita-bhaumik can you please cherry-pick this and raise PR against release-1.0 branch as well. |
|
@aevo98765 @samarpita-bhaumik Looks like this PR merge re-added some updated commit history. Looks like the PR was pushed from the main branch of the fork to the main branch of the UI repo. And I think fork's main branch was not rebased. This end-up updating around 46 commits from different authors and made @samarpita-bhaumik as a co-author to these commits. I am looking into fixing it. @samarpita-bhaumik For future PR, please use the a separate branch in your local repo and push it against the upstream main branch, that way it only shows the commit that is being pushed to the local branch and keeps the commit history clean. |
|
@samarpita-bhaumik would you be able to create a new branch and pull request and we will try this again! Sorry about all the confusion. |
|
@aevo98765 Sure I am creating another PR from a new branch |
I updated the githublogin.tsx by removing the Page and PageSection tags, replacing them with div tags. Additionally, I modified the githublogin.css to include both vertical and horizontal scrolling, ensuring the page adapts to any window size.
Issue resolved by this Pull Request:
Resolves # 164
These are the screenshots when the window is minimized to the size of the mobile view: