fix umami prod argocd #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gregory-Pereira
added
deployment
changes: - creating qa and prod overlays - better manifest labeling - docs updates with deployment timing information Signed-off-by: greg pereira <[email protected]>
Gregory-Pereira
force-pushed
the
umami-prod-and-qa-overlays
branch
from
e0fdfaf to
de7be5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Argocd was failing to deploy to prod because previously the sealed-secret was not included in the
kustomization.yamlfile. That was orrigionally intentional so we could switch between theumami-secret.yamlfor QA and theumami-secret.sealedsecret.yamlfor Prod, but this became complex to maintain without separate overlays.This PR creates the overlays to fix this plus some other small improvements.
changes: