Skip to content
This repository has been archived by the owner on Feb 22, 2024. It is now read-only.

Switch to Buffer.from as new Buffer deprecated #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

buckett
Copy link
Contributor

@buckett buckett commented Feb 14, 2023

Since nodejs 6 new Buffer(…) has been deprecated and shouldn’t be used, this switches to the newer method and this gets rid of the warning.

Fixes #46

Thanks for submitting a PR! We want to make contributing to the Canvas Data CLI as easy as possible.
Please read these instructions carefully:

  • Explain the motivation for making this change.
  • Provide a test plan demonstrating that the code is solid.
  • Match the code formatting of the rest of the codebase.
  • Make sure to add tests to help keep code coverage up.

Motivation (required)

Fixes a warning

Test Plan (required)

Check that the canvas-data-cli still works in making authenticated requests.

Next Steps

  • Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.
  • Make sure all tests pass, we will run this on jenkins but you can run it yourself with the build.sh script.

Since nodejs 6 `new Buffer(…)` has been deprecated and shouldn’t be used, this switches to the newer method and this gets rid of the warning.

Fixes instructure#46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uses deprecated new Buffer() which gives warning
1 participant