Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendar: default day of event/todo creation #2888

Merged
merged 4 commits into from
Sep 12, 2024
Merged

Calendar: default day of event/todo creation #2888

merged 4 commits into from
Sep 12, 2024

Conversation

rh12
Copy link
Contributor

@rh12 rh12 commented Sep 10, 2024 •
edited
Loading

refs: MBL-17816
affects: Student
release note: New calendar todos now use the currently selected date as default.

Test plan:

  • Verify both AddEvent & AddToDo screens use the currently selected date as default, instead of today.
  • Verify EditEvent & EditTodo screens are unaffected by current selection.
  • Verify default date matches the selected value after various selection methods, like
    • tapping on a day in calendar
    • swiping months or weeks
    • using Today button to reselect today

Checklist

  • Follow-up e2e test ticket created
  • Tested on phone
  • Tested on tablet

@rh12 rh12 self-assigned this Sep 10, 2024
@inst-danger
Copy link
Contributor

inst-danger commented Sep 10, 2024 •
edited
Loading

Student Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Sep 10, 2024 •
edited by jira bot
Loading

Fails
🚫 Build failed, skipping coverage check

Release Note:

New calendar events and todos now use the currently selected date as default.

Affected Apps: Student

MBL-17816

❌ XCTest failed: CoreTests/CourseSyncCleanupInteractorTests/testSharedOfflineDirectoryForUserDeleted 
XCTAssertFalse failed

Generated by 🚫 dangerJS against d3811c5

szabinst
szabinst previously approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@szabinst szabinst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA + 1

@rh12
Add selectedDate to createCalendarEvent
ddc1ae2 
refs: MBL-17816
affects: Student
release note: New calendar events and todos now use the currently selected date as default.

test plan: See PR description
@rh12
Add selectedDate to createCalendarToDo
bbd49a5
@rh12
Fix Today button not updating selectedDate
2076bc8
@rh12
Add tests
d3811c5
@rh12 rh12 force-pushed the feature/MBL-17816-Default-day-of-event-creation branch from a570343 to d3811c5 Compare September 11, 2024 13:12
@szabinst szabinst self-requested a review September 11, 2024 13:14
ndrsszsz
ndrsszsz approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@ndrsszsz ndrsszsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA +1

@rh12 rh12 merged commit d960294 into master Sep 12, 2024
2 of 4 checks passed
@rh12 rh12 deleted the feature/MBL-17816-Default-day-of-event-creation branch September 12, 2024 06:38
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szabinst szabinst szabinst approved these changes

@ndrsszsz ndrsszsz ndrsszsz approved these changes

@vargaat vargaat Awaiting requested review from vargaat vargaat is a code owner

Assignees

@rh12 rh12

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rh12 @inst-danger @szabinst @ndrsszsz