Fix submit of bookmark editor (#728)

int128 · Jun 23, 2024 · 2e224a5 · 2e224a5
1 parent 93ff799
commit 2e224a5
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 9 deletions.
diff --git a/src/BookmarkEditor/component.css b/src/BookmarkEditor/component.css
@@ -7,7 +7,7 @@
 dialog.BookmarkEditor {
   width: auto;
   max-width: 800px;
-  padding: var(--size-wide-gap);
+  padding: inherit;
   color: inherit;
   background-color: var(--palette-3);
   border-style: none;
@@ -22,6 +22,7 @@ dialog.BookmarkEditor::backdrop {
 .BookmarkEditor__Form {
   display: grid;
   gap: var(--size-gap);
+  padding: var(--size-wide-gap);
 }
 
 .BookmarkEditor__Group {

diff --git a/src/Dialog/component.tsx b/src/Dialog/component.tsx
@@ -29,10 +29,8 @@ const DialogComponent: FC<DialogComponentProps> = ({ children, open, onRequestCl
       className={className}
       onCancel={onRequestClose}
       onClick={(e) => {
-        if (dialogRef.current === null) {
-          return
-        }
-        if (!isClickedInRect(e, dialogRef.current.getBoundingClientRect())) {
+        // Close the dialog when the backdrop is clicked
+        if (e.target === dialogRef.current) {
           onRequestClose()
         }
       }}
@@ -46,6 +44,3 @@ const DialogComponent: FC<DialogComponentProps> = ({ children, open, onRequestCl
 }
 
 export default DialogComponent
-
-const isClickedInRect = (e: React.MouseEvent, r: DOMRect): boolean =>
-  e.clientX > r.left && e.clientX < r.right && e.clientY > r.top && e.clientY < r.bottom
diff --git a/src/Preferences/component.css b/src/Preferences/component.css
@@ -5,7 +5,7 @@
 }
 
 dialog.Preferences {
-  padding: var(--size-wide-gap);
+  padding: inherit;
   color: inherit;
   background-color: var(--palette-3);
   border-style: none;
@@ -20,6 +20,7 @@ dialog.Preferences::backdrop {
 .Preferences__Form {
   display: grid;
   gap: var(--size-gap);
+  padding: var(--size-wide-gap);
 }
 
 .Preferences h2 {