Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust fee to decimals by genesis and properly charge it before bumping nonce #1622

Merged
merged 9 commits into from
Oct 26, 2024
Merged

adjust fee to decimals by genesis and properly charge it before bumping nonce #1622

merged 9 commits into from
Oct 26, 2024

Conversation

brenzi
Copy link
Collaborator

@brenzi brenzi commented Oct 25, 2024 •
edited
Loading

  • STF fees are defined as fractions of a unit on L1
  • units are derived by a hardcoded lookup from genesis hash to decimals

@brenzi brenzi added A2-applibs Affects app-libs, i.e. runtime or stf B1-releasenotes C1-low 📌 Does not elevate a release containing this beyond "low priority" E0-breaksnothing labels Oct 25, 2024
@brenzi brenzi merged commit 036e859 into master Oct 26, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clangenb clangenb clangenb left review comments

Assignees
No one assigned
Labels
A2-applibs Affects app-libs, i.e. runtime or stf B1-releasenotes C1-low 📌 Does not elevate a release containing this beyond "low priority" E0-breaksnothing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brenzi @clangenb