Skip to content

Commit

Permalink
mptcp: refer to 'MPTCP' socket in comments
Browse files Browse the repository at this point in the history
we used to call it 'master' socket at the early stages of MPTCP
development, but the correct wording is 'MPTCP' socket opposed to 'TCP
subflows': convert the last 3 coments to use a more appropriate term.

Signed-off-by: Davide Caratti <[email protected]>
  • Loading branch information
dcaratti authored and intel-lab-lkp committed May 15, 2024
1 parent 13f8e00 commit 7bcc293
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions net/mptcp/protocol.c
Original file line number Diff line number Diff line change
Expand Up @@ -2202,7 +2202,7 @@ static int mptcp_recvmsg(struct sock *sk, struct msghdr *msg, size_t len,
if (skb_queue_empty(&msk->receive_queue) && __mptcp_move_skbs(msk))
continue;

/* only the master socket status is relevant here. The exit
/* only the MPTCP socket status is relevant here. The exit
* conditions mirror closely tcp_recvmsg()
*/
if (copied >= target)
Expand Down Expand Up @@ -3521,7 +3521,7 @@ void mptcp_subflow_process_delegated(struct sock *ssk, long status)
static int mptcp_hash(struct sock *sk)
{
/* should never be called,
* we hash the TCP subflows not the master socket
* we hash the TCP subflows not the MPTCP socket
*/
WARN_ON_ONCE(1);
return 0;
Expand Down
2 changes: 1 addition & 1 deletion net/mptcp/subflow.c
Original file line number Diff line number Diff line change
Expand Up @@ -1719,7 +1719,7 @@ int mptcp_subflow_create_socket(struct sock *sk, unsigned short family,
mptcp_sockopt_sync_locked(mptcp_sk(sk), sf->sk);
release_sock(sf->sk);

/* the newly created socket really belongs to the owning MPTCP master
/* the newly created socket really belongs to the owning MPTCP
* socket, even if for additional subflows the allocation is performed
* by a kernel workqueue. Adjust inode references, so that the
* procfs/diag interfaces really show this one belonging to the correct
Expand Down

0 comments on commit 7bcc293

Please sign in to comment.