Skip to content

Commit

Permalink
Squash to "selftests/bpf: Add mptcp subflow subtest"
Browse files Browse the repository at this point in the history
Use pm_nl_ctl when 'ip mptcp' fails.
Use SYS_NOFAIL in _ss_search().

Signed-off-by: Geliang Tang <[email protected]>
  • Loading branch information
Geliang Tang authored and intel-lab-lkp committed May 11, 2024
1 parent 11b1ce7 commit a84a4d7
Showing 1 changed file with 6 additions and 11 deletions.
17 changes: 6 additions & 11 deletions tools/testing/selftests/bpf/prog_tests/mptcp.c
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,10 @@ static int endpoint_init(char *flags)
SYS(fail, "ip -net %s link set dev veth1 up", NS_TEST);
SYS(fail, "ip -net %s addr add %s/24 dev veth2", NS_TEST, ADDR_2);
SYS(fail, "ip -net %s link set dev veth2 up", NS_TEST);
SYS(fail, "ip -net %s mptcp endpoint add %s %s", NS_TEST, ADDR_2, flags);
if (SYS_NOFAIL("ip -net %s mptcp endpoint add %s %s", NS_TEST, ADDR_2, flags)) {
SYS(fail, "ip netns exec %s ./mptcp_pm_nl_ctl add %s flags %s",
NS_TEST, ADDR_2, flags);
}

return 0;
fail:
Expand All @@ -355,16 +358,8 @@ static int endpoint_init(char *flags)

static int _ss_search(char *src, char *dst, char *port, char *keyword)
{
char cmd[128];
int n;

n = snprintf(cmd, sizeof(cmd),
"ip netns exec %s ss -Menita src %s dst %s %s %d | grep -q '%s'",
NS_TEST, src, dst, port, PORT_1, keyword);
if (n < 0 || n >= sizeof(cmd))
return -1;

return system(cmd);
return SYS_NOFAIL("ip netns exec %s ss -Menita src %s dst %s %s %d | grep -q '%s'",
NS_TEST, src, dst, port, PORT_1, keyword);
}

static int ss_search(char *src, char *keyword)
Expand Down

0 comments on commit a84a4d7

Please sign in to comment.