mptcp: fix bogus socket state update

Since the blamed commit, closing the first subflow can unexpectedly change the msk socket state. In case of incoming fastclose, that allows a listen() call to successfully race with a blocking recvmsg() potentially causing the latter to hit a divide by zero bug in cleanup_rbuf/__tcp_select_window(). Address the issue simply dropping the bogus state change. Fixes: b29fcfb ("mptcp: full disconnect implementation") Signed-off-by: Paolo Abeni <[email protected]>
intel-lab-lkp · Jun 27, 2023 · eee8e21 · eee8e21
1 parent e7e88d6
commit eee8e21
Showing 1 changed file with 0 additions and 1 deletion.
diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c
@@ -2377,7 +2377,6 @@ static void __mptcp_close_ssk(struct sock *sk, struct sock *ssk,
 		 * disconnect should never fail
 		 */
 		WARN_ON_ONCE(tcp_disconnect(ssk, 0));
-		msk->subflow->state = SS_UNCONNECTED;
 		mptcp_subflow_ctx_reset(subflow);
 		release_sock(ssk);